DataGrid: Fix editing of nullable values such as int?#8231
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Feb 24, 2024
Merged
DataGrid: Fix editing of nullable values such as int?#8231ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
snakex64
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8231 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 394 394
Lines 11765 11767 +2
Branches 2384 2385 +1
=======================================
+ Hits 10381 10383 +2
Misses 857 857
Partials 527 527 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
Feb 24, 2024
Member
|
Thanks! |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix a bug with the datagrid where it was impossible to clear a value for nullable structs such as
int?,double?, etc.We could set a value, ex "25" but then if we clear the text "25" and hit "enter" there was a crash.
Try emptying the "Age" cell in one of the row: https://try.mudblazor.com/snippet/ckwoYmmoLvDaySwa
How Has This Been Tested?
Tested using a small example and added a unit test
Types of changes
Checklist:
dev).