MudColor: Fix ColorRgbDarken and ColorRgbLighten#8206
Merged
henon merged 2 commits intoMudBlazor:devfrom Feb 20, 2024
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8206 +/- ##
=======================================
Coverage 88.22% 88.23%
=======================================
Files 394 394
Lines 11764 11764
Branches 2385 2383 -2
=======================================
+ Hits 10379 10380 +1
Misses 857 857
+ Partials 528 527 -1 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
Feb 20, 2024
henon
changed the title
Contributor
|
Perfect, thank you! |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
* extended theme provider tests * fix: CalculateHSL is called not only for hex string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not complete initialization of
MudColor's hsl values lead to hard to detect bugs if those values are used likeColorRgbDarkenorColorRgbLightenresolves #8205
How Has This Been Tested?
Unit tests are added
tests are parse rgb value and then darken it and compares with same darken colors but created from rgb parameters
I have created new unit tests
Types of changes
Checklist:
dev).