Skip to content

MudTextField: Preserve scroll position while typing with AutoGrow and update when window is resized#8193

Merged
henon merged 5 commits intoMudBlazor:devfrom
danielchalmers:improve-auto-grow
Feb 19, 2024
Merged

MudTextField: Preserve scroll position while typing with AutoGrow and update when window is resized#8193
henon merged 5 commits intoMudBlazor:devfrom
danielchalmers:improve-auto-grow

Conversation

@danielchalmers
Copy link
Member

Description

Resolves #8152 and part of #8091.

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before:

Video.mp4
Video.mp4

After:

Video2.mp4
Video2.mp4

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 17, 2024
@codecov
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee80e01) 88.25% compared to head (db09bb2) 88.24%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8193      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.01%     
==========================================
  Files         394      394              
  Lines       11742    11751       +9     
  Branches     2377     2380       +3     
==========================================
+ Hits        10363    10370       +7     
- Misses        854      855       +1     
- Partials      525      526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon February 17, 2024 23:51
@danielchalmers danielchalmers changed the title MudTextField: Preserve scroll position while typing with auto grow and update when window is resized MudTextField: Preserve scroll position while typing with AutoGrow and update when window is resized Feb 18, 2024
@henon henon merged commit 892a1de into MudBlazor:dev Feb 19, 2024
@henon
Copy link
Contributor

henon commented Feb 19, 2024

Awesome @danielchalmers, thanks a lot!

danielchalmers added a commit to danielchalmers/JournalApp that referenced this pull request Feb 20, 2024
danielchalmers added a commit to danielchalmers/JournalApp that referenced this pull request Mar 7, 2024
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
… update when window is resized (MudBlazor#8193)

* AutoGrow: Fix scrollbar flashing
* AutoGrow: Preserve scroll position better Fixes MudBlazor#8152
* AutoGrow: Update when window is resized MudBlazor#8091
* AutoGrow: Leave scrollbars alone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudTextField AutoGrow: scroll position resets if height is more than 100%

2 participants