MudDataGrid: Make grouping two-way bindable (#8159)#8160
MudDataGrid: Make grouping two-way bindable (#8159)#8160henon merged 2 commits intoMudBlazor:devfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #8160 +/- ##
==========================================
+ Coverage 88.12% 88.25% +0.12%
==========================================
Files 394 394
Lines 11760 11743 -17
Branches 2384 2378 -6
==========================================
Hits 10364 10364
+ Misses 871 854 -17
Partials 525 525 ☔ View full report in Codecov by Sentry. |
|
Hello. Thanks for the PR. Can you add unit tests for this? |
|
@peterthorpe81 this might be related to your PR #8041 but I am not sure. Can you take a quick look? |
|
Hi @ScarletKuro , unit test added. |
|
@henon should we just merge it without @tjscience consent? IIRC this was asked even in old datagrid to have the ability to toggle groupping on/off |
|
@tjscience FYI, this is a pretty simple PR, so we are confident in merging this w/o your review. @Gopichandar Thanks for your contribution! |
|
@henon sorry I didn't respond sooner, I can see the PR is merged. Yes I think its related as this PR seems to have the same two-way binding bug as I created with Hidden parameter. If you use the modified example below. Toggling the "Group Category" switch will do nothing as there is an If you removed the internal bool grouping and used the Grouping parameter direct for state that creates the same issues I am indicating in #8041 i.e. you can't modify grouping in grid if you put Grouping="true" or use an expression. |
|
Dang :( |
…or#8160) * MudDataGrid: grouping changed callback added fot notification * MudDataGrid: unit test added for Grouping binding --------- Co-authored-by: Gopichandar <[email protected]>
MudDataGrid: grouping changed callback added for notification
Description
Fixes #8159
How Has This Been Tested?
visually
Types of changes
Checklist:
dev).