Skip to content

Add X (formerly Twitter) logo to Brands.cs#8135

Merged
henon merged 1 commit intoMudBlazor:devfrom
marknoble:patch-1
Feb 6, 2024
Merged

Add X (formerly Twitter) logo to Brands.cs#8135
henon merged 1 commit intoMudBlazor:devfrom
marknoble:patch-1

Conversation

@marknoble
Copy link
Contributor

@marknoble marknoble commented Feb 5, 2024

Description

Adding the X logo since it's been the official logo for over 6 months. SVG path sourced from: https://about.twitter.com/en/who-we-are/brand-toolkit Retrieved on 2024-02-05

Outdated Twitter logo can now be replaced by X logo while still retaining the old logo as not to break people who haven't updated their code. Resolves #8136

How Has This Been Tested?

Visually checked the SVG.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Adding the X logo since it's been the official logo for over 6 months.
SVG path sourced from: https://about.twitter.com/en/who-we-are/brand-toolkit 
Retrieved on 2024-02-05
@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Feb 5, 2024
@ScarletKuro ScarletKuro requested a review from henon February 5, 2024 22:00
@henon henon changed the title Update Brands.cs to add X logo Add X (formerly Twitter) logo to Brands.cs Feb 6, 2024
@henon henon merged commit 6a92127 into MudBlazor:dev Feb 6, 2024
@henon
Copy link
Contributor

henon commented Feb 6, 2024

Thanks @marknoble

@marknoble marknoble deleted the patch-1 branch February 6, 2024 15:16
@ScarletKuro
Copy link
Member

@marknoble Hi.
Your svg is kinda broken, the default size is too big.
Have you not tested it with MudIcon etc?
Ekran_goruntusu_2024-02-09_144739

@ScarletKuro
Copy link
Member

The path should fit in 24x24

@henon
Copy link
Contributor

henon commented Feb 9, 2024

making a mental note to always request a screenshot for visual PRs

@marknoble
Copy link
Contributor Author

The path should fit in 24x24

Ok. I'll take a look and submit a fix with screenshot.

@marknoble marknoble restored the patch-1 branch February 10, 2024 17:15
@mckaragoz mckaragoz mentioned this pull request Feb 10, 2024
6 tasks
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Adding the X logo since it's been the official logo for over 6 months.
SVG path sourced from: https://about.twitter.com/en/who-we-are/brand-toolkit 
Retrieved on 2024-02-05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Twitter changed it's name to X 6 months ago and the new logo isn't available in Icons.Custom.Brands

3 participants