DataGrid: Throw exception when ServerData and QuickFilter are supplied (#7998)#8010
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8010 +/- ##
=======================================
Coverage 88.07% 88.08%
=======================================
Files 393 393
Lines 11742 11748 +6
Branches 2375 2376 +1
=======================================
+ Hits 10342 10348 +6
Misses 874 874
Partials 526 526 ☔ View full report in Codecov by Sentry. |
|
If this PR is accepted, I will do a similar PR to |
|
@henon, can you review this PR? |
|
@tjscience FYI |
|
Normally you would query the DataSource remotely to apply the filter wouldn't you? |
|
Yes, the quickfilter would only give you a filtered view of the current page which is not what you would expect. |
Yes, with
A solution is to load all elements and apply If you want use |
|
Thanks @vernou ! |
|
Hey @vernou did you make progress on the |
Also the additional exceptions would be great. Forgot to remove mine as I am switching to |
|
From the PR #8026, when After I go on other thing and forget the parameter |
|
@dennisrahmen You can found example to use |
|
@vernou I know the example of the I just had a colleague at work completely replace all DataGrids in a Project since he thought only I was on vacation that week. :( |
Fix #7998
Description
The PR #4664 enable
QuickFilteron data provided byServerData.But this has bug like describing in the PR and the ticket #7998
ServerDataallows to load only the data displayed on the current page.But
QuickFilterneeds all data to be loaded to work properly.These tow parameters are exclusive.
The modification fix is to throw a exception when both parameters are supplied.
How Has This Been Tested?
A unit test was added to check the exception is correctly throw.
Also, the test that check
ServerDatawithQuickFilterwas removed.Types of changes
This is breaking change, because all code was supplied both parameters
ServerDataandQuickFilterwill stop to work.But it's legit.
Checklist:
dev).