Skip to content

MudTable: fix Bordered in RTL mode#8008

Merged
henon merged 2 commits intoMudBlazor:devfrom
henon:table-bordered-rtl
Jan 19, 2024
Merged

MudTable: fix Bordered in RTL mode#8008
henon merged 2 commits intoMudBlazor:devfrom
henon:table-bordered-rtl

Conversation

@henon
Copy link
Contributor

@henon henon commented Jan 9, 2024 •
edited
Loading

Description

Fixes #7937

Renders correct borders with bordered table in RTL

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've visually tested

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 9, 2024
@henon
Copy link
Contributor Author

henon commented Jan 9, 2024

@hamiddd1980 I don't get it. I applied the changes you were suggesting in #7937 in this PR but when I compile this the borders are still wrong. Could you please check?

@hamiddd1980
Copy link

hamiddd1980 commented Jan 10, 2024

Dear @henon, I have uploaded a sample code at https://try.mudblazor.com/snippet/GOGeEFuDreHOxABo
.please review it and let me know about any more information.

@henon
Copy link
Contributor Author

henon commented Jan 10, 2024

@hamiddd1980 thanks for making the example. I had it correct but somehow the freshly compiled docs did not show a change yesterday even after a clean build. today I tried again and it works.
The only thing I noticed is that in mobile mode the borders are also shown on the side of the card which is an optical bug. Would you be able to fix that too for both RTL and LTR?

image
image

@codecov
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6b563b) 88.07% compared to head (0b825c6) 88.08%.
Report is 11 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #8008   +/-   ##
=======================================
  Coverage   88.07%   88.08%           
=======================================
  Files         393      393           
  Lines       11742    11748    +6     
  Branches     2375     2376    +1     
=======================================
+ Hits        10342    10348    +6     
  Misses        874      874           
  Partials      526      526

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 397efe4 into MudBlazor:dev Jan 19, 2024
@henon
Copy link
Contributor Author

henon commented Jan 19, 2024

Thanks @hamiddd1980 for your contribution!

@henon henon deleted the table-bordered-rtl branch January 19, 2024 21:12
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@henon @biegehydra
MudTable: fix Bordered in RTL mode (MudBlazor#8008)
0db636f 
* MudTable: fix Bordered in RTL mode
* MudTable: fix Bordered on small screens

Co-authored-by: hamiddd1980 <[email protected]>
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG : For Right To Left Languages the MudTable Component is not shown correctly

2 participants

@henon @hamiddd1980