Merged
Conversation
github-actions
bot
added
bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #7975 +/- ##
==========================================
- Coverage 87.41% 87.40% -0.01%
==========================================
Files 395 395
Lines 11745 11745
Branches 2373 2373
==========================================
- Hits 10267 10266 -1
+ Misses 950 949 -1
- Partials 528 530 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
The text is centered now and doesn't jump around when the checkmark is added |
Contributor
|
Readded the |
Contributor
We decided to fix this little render bug later. It is an experimental component after all |
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
* Fix Rounded * Fix None Outline Borders --------- Co-authored-by: Meinrad Recheis <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of PRs #7309 and #7948
Todo:
fix the bug with rounded + outline:
make the icon 4px smaller when ShowText is true
ShowText && ShowIcon && Icon!=null || SelectedIcon!=null: balance the space taken up by the icon on the left with padding on the right so that the text doesn't shift right when the selected icon shows up:
Outline: make sure the outline's corner radius is a tiny bit smaller than the toggle item's so that there is no visible space between them:
How Has This Been Tested?
Types of changes
Checklist:
dev).