Skip to content

MudTextField: Fix initial height if AutoGrow is enabled (#7839)#7849

Merged
henon merged 1 commit intoMudBlazor:devfrom
AntMaster7:fix/textfield-autogrow-initial-grow
Dec 3, 2023
Merged

MudTextField: Fix initial height if AutoGrow is enabled (#7839)#7849
henon merged 1 commit intoMudBlazor:devfrom
AntMaster7:fix/textfield-autogrow-initial-grow

Conversation

@AntMaster7
Copy link
Contributor

@AntMaster7 AntMaster7 commented Dec 2, 2023

Description

How Has This Been Tested?

Resolves #7839

I did test it visually and with the example code given in the associated issue. When I implemented this feature initially I did only check the scenario when the text changes after initialization but missed the case that the text might span multiple lines after initialization. The issue has been fixed with a change to the javascript file. In this case no unit test is possible.

@henon @ScarletKuro

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests. Unit tests are not possible is this case.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Dec 2, 2023
@henon henon merged commit 3d5aa55 into MudBlazor:dev Dec 3, 2023
@henon
Copy link
Contributor

henon commented Dec 3, 2023

Thanks!

TDroogers added a commit to TDroogers/MudBlazor that referenced this pull request Dec 3, 2023
TDroogers added a commit to TDroogers/MudBlazor that referenced this pull request Dec 3, 2023
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AutoGrow doesn't grow initially if Text is bound

2 participants