Skip to content

Build: Move global.json so it used in all repo ops#7802

Merged
mikes-gh merged 1 commit intoMudBlazor:devfrom
mikes-gh:global-move
Nov 23, 2023
Merged

Build: Move global.json so it used in all repo ops#7802
mikes-gh merged 1 commit intoMudBlazor:devfrom
mikes-gh:global-move

Conversation

@mikes-gh
Copy link
Contributor

@mikes-gh mikes-gh commented Nov 22, 2023

Description

Following on from #7799
Because dotnet CLI looks for global.json from working directory and upwards this PR moves the global.json to the root of the repo.
This ensures all dotnet commands respect the SDK version global.json specifies.

How Has This Been Tested?

On my fork by running build and publish to check they both use fixed SDK

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Nov 22, 2023
@mikes-gh
Copy link
Contributor Author

Merging this as want to get the build back to green..

@mikes-gh mikes-gh merged commit 49a74ab into MudBlazor:dev Nov 23, 2023
@henon
Copy link
Contributor

henon commented Nov 23, 2023

Awesome, thanks for merging right away.

ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@mikes-gh mikes-gh deleted the global-move branch January 3, 2024 18:15
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants