Skip to content

MudTablePager: Fix Vertical Alignment of Select text (#7501, #7507)#7670

Merged
henon merged 1 commit intoMudBlazor:devfrom
phamilton4321:phamilton4321-patch-2
Oct 20, 2023
Merged

MudTablePager: Fix Vertical Alignment of Select text (#7501, #7507)#7670
henon merged 1 commit intoMudBlazor:devfrom
phamilton4321:phamilton4321-patch-2

Conversation

@phamilton4321
Copy link
Contributor

Description

Followup for issue #7501 and pull request #7507.
The original commit solved the problem, but style is overwritten. Need to apply !important that it will be taken in live application.

How Has This Been Tested?

Yes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

Followup for issue MudBlazor#7501 and pull request MudBlazor#7507.
The original commit solved the problem, but style is overwritten.
Need to apply !important that it will be taken in live application.
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1234905) 90.57% compared to head (dafbd1e) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7670      +/-   ##
==========================================
- Coverage   90.57%   86.19%   -4.39%     
==========================================
  Files         427      427              
  Lines       15233    15233              
  Branches        0     3321    +3321     
==========================================
- Hits        13798    13130     -668     
+ Misses       1435     1422      -13     
- Partials        0      681     +681     

see 194 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon changed the title Fix for #7507 MudTablePager: Fix Vertical Alignment of Select text (#7501, #7507, #7670) Oct 20, 2023
@henon henon changed the title MudTablePager: Fix Vertical Alignment of Select text (#7501, #7507, #7670) MudTablePager: Fix Vertical Alignment of Select text (#7501, #7507) Oct 20, 2023
@henon henon merged commit 04703e6 into MudBlazor:dev Oct 20, 2023
@henon
Copy link
Contributor

henon commented Oct 20, 2023

Thanks!

@phamilton4321 phamilton4321 deleted the phamilton4321-patch-2 branch October 30, 2023 12:02
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…udBlazor#7507, MudBlazor#7670)

Followup for issue MudBlazor#7501 and pull request MudBlazor#7507.
The original commit solved the problem, but style is overwritten.
Need to apply !important that it will be taken in live application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants