MudForm: Catch all OnTimerComplete errors and log to console.#7626
Merged
henon merged 1 commit intoMudBlazor:devfrom Oct 10, 2023
Merged
MudForm: Catch all OnTimerComplete errors and log to console.#7626henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #7626 +/- ##
==========================================
- Coverage 90.60% 90.57% -0.03%
==========================================
Files 427 427
Lines 15218 15223 +5
==========================================
Hits 13788 13788
- Misses 1430 1435 +5
☔ View full report in Codecov by Sentry. |
Contributor
|
Thanks @Mr-Technician ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In some edge cases, the MudForm will throw an error due to the timer not being disposed correctly and attempting to interact with the component following disposal. @henon and I discussed it and do not presently have a fix for the issue, but this PR will at least prevent crashes.
How Has This Been Tested?
All existing unit tests pass.
Types of changes
Checklist:
dev).