ScrollToTopExamples: Correct Setup section button positioning#7617
Merged
henon merged 1 commit intoMudBlazor:devfrom Oct 14, 2023
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7617 +/- ##
==========================================
- Coverage 90.60% 90.59% -0.02%
==========================================
Files 427 427
Lines 15218 15218
==========================================
- Hits 13788 13786 -2
- Misses 1430 1432 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
Awesome! Thanks a lot! |
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While examining the "Scroll To Top Examples" page, I spotted an inconsistency in the positioning of the button. Expected at the bottom right of Setup section container, it appeared at the bottom right of the entire page due to a CSS positioning conflict. The position attribute of the
absoluteclass was being overridden by the.mud-scroll-to-topclass.To resolve this and avoid future issues, I strengthened the specificity of several position attributes by adding
!importantin the_position.scssfile:How Has This Been Tested?
Types of changes
Visual Demonstrations
To provide clearer context:
Before the Fix:
After the Fix:
Checklist:
dev).