MudDropZone: Add ItemClassSelector parameter.#7599
Conversation
github-actions
bot
added
enhancement
|
Hi. I only see you pushed changes to |
This reverts commit 55b8dc9.
…f the dropzone using funciton. Added test for this.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #7599 +/- ##
==========================================
- Coverage 90.58% 86.16% -4.42%
==========================================
Files 427 427
Lines 15224 15249 +25
Branches 0 3323 +3323
==========================================
- Hits 13791 13140 -651
+ Misses 1433 1425 -8
- Partials 0 684 +684
☔ View full report in Codecov by Sentry. |
|
Please check it now. I reverted incorrect commit to gitignore and pushed correct commit to the PR. |
…cute code when draging starts (Similar to ItemDropped).
henon
left a comment
henon
left a comment
There was a problem hiding this comment.
The item class selector looks good. The additional event is not needed I think, at least I see no reason why two events sending exactly the same data are being invoked in the same place. Please remove or make your case why it is needed.
henon
changed the title
…isitng TransactionStarted event. Corrected the Test for it.
henon
left a comment
henon
left a comment
There was a problem hiding this comment.
Actually I argued that the ItemPicked event is not really needed because the TransactionStarted event is already serving the same purpose, it is just not named as intuitively as ItemPicked. So unless you can provide an argument why TransactionStarted is not suitable I'd say let's remove it and just add to the summary of TransactionStarted that it is raised when an item is picked.
|
Thanks for the clarification. Please review if I get it correct this time. |
…oviding Summary." This reverts commit 48c660b.
|
By the way, you added a test component but I don't see a unit test that checks that the class selector func works and that the event is called. We'd need that also to make sure future PRs will not accidentally break these features. |
…lector and OnItemPicked.
|
Added two unit tests. Please check. |
|
Great, thanks @RPalejiya ! |
* Adding functionality to Dropzone Item to apply custom class on item of the dropzone using funciton. Added test for this. * DropZone - Adding eventhandler for "ItemPicked" to provide way to execute code when draging starts (Similar to ItemDropped). --------- Co-authored-by: Ravi Palejiya <[email protected]>
3 participants
Description
Currently there is no way to define class for draggable items of a DropZone. This change will allow to define ItemsClassSelector on and components. discussion #6300How Has This Been Tested?
Added test case "DropzoneItemClassSelectorTest.razor" No new test. NoneTypes of changes
Checklist:
dev).