Can you add a test case that fails without the fix and passes with it, please? This will make sure your fix will never unintentionally be corrupted by future PRs.

@0xced This is an important bug fix PR, you are already 90% of the way. If you can complete, we'd appreciate it!

@henon actually, now when I think about it, if you add this to the DataGrid.AddFilterAsync and just compare by the title, you won't be able to do something like this.

So either you shouldn't allow duplication when clicking the UI add filter like it's done now, or you need more complicated compare that takes not only column title into the account.

Another reason not to call DataGrid.AddFilterAsync is because it eventually calls the ServerData callback. I was very surprised to see database query logs just by opening the filter panel, without having defined any filter yet!

Can you add a test case that fails without the fix and passes with it, please? This will make sure your fix will never unintentionally be corrupted by future PRs.

I'll try but I may not have time to do it soon. So if anyone else want to add a test, please go ahead.

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d48ea23) 88.22% compared to head (4edbad8) 88.22%.

@@           Coverage Diff           @@
##              dev    #7594   +/-   ##
=======================================
  Coverage   88.22%   88.22%           
=======================================
  Files         394      394           
  Lines       11755    11764    +9     
  Branches     2381     2385    +4     
=======================================
+ Hits        10371    10379    +8     
  Misses        857      857           
- Partials      527      528    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xced only a missing test case prevents this PR from being released.

I just added a test case in 4edbad8 so this should be ready to merge.

Thanks a lot @0xced !