DataGridExamples: Fix item removal when list is empty#7571
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7571 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 427 427
Lines 15216 15217 +1
=======================================
+ Hits 13781 13782 +1
Misses 1435 1435
☔ View full report in Codecov by Sentry. |
|
A fix like this has recently been merged: #7557 |
I see it was closed for some reason, not merged? |
ai, my bad |
Actually, the PR was part of a collaborative exercise between a friend and me. We decided to learn about contributing to open source projects together. He gave me this specific fix as a task, using MudBlazor as our starting point. The closure was intentional, serving more as a learning experience than a genuine contribution. |
|
@henon merged this without second review, as this change looks simple enough. |
|
Sure, thanks @ScarletKuro! Thank you @MohamedYassin-J ! |
Description
During interactions with the data grid examples, specifically the 'Observability' example, I encountered an issue. An error arises when all items from the data grid are removed, and a further attempt to remove an item is made. The root cause was identified as a missing verification to determine if the list of items is already empty before initiating item removal. This update rectifies this oversight, ensuring smooth item management.
How Has This Been Tested?
To ensure the robustness of the implemented fix:
Types of changes
Visual Demonstrations
To better understand the issue and its subsequent resolution, please refer to the GIFs below:
Before the Fix:
After the Fix:
Checklist:
dev).