FYI -- had to add .Click()s to some of the tests because of the changes to OnMouseUp, as far as I can tell this is the right way to do it (mousedown -> mouseup -> click -> action).

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9a6a0d5) 90.56% compared to head (5b90d71) 90.56%.

@@           Coverage Diff           @@
##              dev    #7517   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files         427      427           
  Lines       15210    15213    +3     
=======================================
+ Hits        13775    13778    +3     
  Misses       1435     1435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thank you for your contribution. Please address the following issues:

The MouseUp logic looks fishy and probably needs correction. The unit tests probably too.

@henon thank you for the feedback and the doubts -- you were right, my implementation was incorrect and based on false assumptions.

My initial assumption was that the OnMouseUp was forcing the view for hours to change to minutes for no reason at all, which isn't the case. It handles switching from hours to minutes on mouse up if the value has changed, which is expected behaviour by existing unit tests.

To avoid messing around with those, the "new" implementation verifies, when a click event is received, if the hour value has changed, and updates the time accordingly.

I also discovered an edge case where switching back to the _initialHour would not update the hour despite the fix, so I introduced a _lastSelectedHour field for a more accurate check (tested against with a specific unit test case).

Edit: I don't mind digging deeper if need be, don't hold back :)

Looking good now, don't worry about it, I make plenty of similar mistakes myself when the day is long.
Thanks @igotinfected !