Skip to content

MudTablePager: Fix Vertical Alignment of Select text (#7501)#7507

Merged
henon merged 1 commit intoMudBlazor:devfrom
phamilton4321:dev
Sep 14, 2023
Merged

MudTablePager: Fix Vertical Alignment of Select text (#7501)#7507
henon merged 1 commit intoMudBlazor:devfrom
phamilton4321:dev

Conversation

@phamilton4321
Copy link
Contributor

@phamilton4321 phamilton4321 commented Sep 14, 2023 •
edited by ScarletKuro
Loading

Fixes: #7501
Fixes the misaligned text of the MudTablePager Select element.

Adds a padding other than for input-root, which should be used in MudTablePager Select item.

Description

Add padding to existing style.

How Has This Been Tested?

Build the css out of the edited file and replaced it in a local project.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

See #7501 for before and after comparison.

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@phamilton4321
FIX MudBlazor#7501
c76f5aa 
Fixes the misaligned text of the MudTablePager Select element.
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (e4f916e) 90.61% compared to head (c76f5aa) 90.56%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7507      +/-   ##
==========================================
- Coverage   90.61%   90.56%   -0.06%     
==========================================
  Files         427      427              
  Lines       15198    15210      +12     
==========================================
+ Hits        13772    13775       +3     
- Misses       1426     1435       +9

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Contributor

henon commented Sep 14, 2023

Can you please post a before and after image? Thanks

@phamilton4321
Copy link
Contributor Author

phamilton4321 commented Sep 14, 2023

Can you please post a before and after image? Thanks

Sure, but they are in the references issue as well.

Before:
267558759-99101f24-76a7-4c5b-af1b-8d6724e615ac

After:
267626527-7d0f0ef0-e910-4c5b-aa17-2ea28d329230

@phamilton4321 phamilton4321 changed the title MudTablePager: Fix Horizontal Alignment of Select text (#7501) MudTablePager: Fix Vertical Alignment of Select text (#7501) Sep 14, 2023
@henon
Copy link
Contributor

henon commented Sep 14, 2023 •
edited
Loading

OK, so if I can trust my eyes the text was 1px too high?

PS: sorry for overlooking the description of the issue.

@phamilton4321
Copy link
Contributor Author

phamilton4321 commented Sep 14, 2023

OK, so if I can trust my eyes the text was 1px too high?

PS: sorry for overlooking the description of the issue.

Yes, the text of the select is currently around 1px too low. After the fix applied it's same height. I know, just a small cosmetic bug, but also an easy fix.

@henon henon merged commit 9a6a0d5 into MudBlazor:dev Sep 14, 2023
@henon
Copy link
Contributor

henon commented Sep 14, 2023

Thanks @phamilton4321 !

phamilton4321 added a commit to phamilton4321/MudBlazor that referenced this pull request Oct 20, 2023
@phamilton4321
Fix for MudBlazor#7507
dafbd1e 
Followup for issue MudBlazor#7501 and pull request MudBlazor#7507.
The original commit solved the problem, but style is overwritten.
Need to apply !important that it will be taken in live application.
@phamilton4321 phamilton4321 mentioned this pull request Oct 20, 2023
Merged
5 tasks
phamilton4321 added a commit to phamilton4321/MudBlazor that referenced this pull request Oct 20, 2023
@phamilton4321
Merge pull request #2 from phamilton4321/phamilton4321-patch-2
68e7bd3 
Fix for MudBlazor#7507
@phamilton4321 phamilton4321 mentioned this pull request Oct 20, 2023
Merged
5 tasks
henon pushed a commit that referenced this pull request Oct 20, 2023
@phamilton4321
MudTablePager: Fix Vertical Alignment of Select text (#7501, #7507, #…
04703e6 
…7670)

Followup for issue #7501 and pull request #7507.
The original commit solved the problem, but style is overwritten.
Need to apply !important that it will be taken in live application.
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@phamilton4321 @ilovepilav
MudTablePager: Fix Vertical Alignment of Select text (MudBlazor#7501, M…
de0f26a 
…udBlazor#7507, MudBlazor#7670)

Followup for issue MudBlazor#7501 and pull request MudBlazor#7507.
The original commit solved the problem, but style is overwritten.
Need to apply !important that it will be taken in live application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon Awaiting requested review from henon

@Mr-Technician Mr-Technician Awaiting requested review from Mr-Technician

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MudTable MudTablePager Horizontal Alignment Fix

2 participants

@phamilton4321 @henon