MudTabs: Fix ActivatePanel ArgumentOutOfRange- and NullReferenceException#7459
Merged
henon merged 1 commit intoMudBlazor:devfrom Sep 2, 2023
Merged
Conversation
github-actions
bot
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #7459 +/- ##
==========================================
- Coverage 90.61% 90.60% -0.02%
==========================================
Files 427 427
Lines 15199 15200 +1
==========================================
- Hits 13773 13772 -1
- Misses 1426 1428 +2
☔ View full report in Codecov by Sentry. |
henon
changed the title
Contributor
|
Thanks @Yomodo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3609
This PR will guard against an
ArgumentOutOfRangeExceptionandNullReferenceExceptionthat can be reproduced in TryMud: https://try.mudblazor.com/snippet/mkQFvwmxsYGypqpP
when the "INDEX 4" button and the first "ITEM FIVE" button are clicked.
I have not included any logic to accomodate the expectation mentioned in the bug report:
For index it could move to the last one or the first one (depending on the direction of the value).
I am willing to create a separate PR for this, if possible.
How Has This Been Tested?
Types of changes
Checklist:
dev).