MudFileUpload: Update summary for MaximumFileCount to better convey its intention (#7227)#7447
Merged
Mr-Technician merged 2 commits intoMudBlazor:devfrom Aug 31, 2023
Conversation
MudFileUpload: Updated summary for MaximumFileCount to better convey its behaviour when AppendMultipleFiles="true" (MudBlazor#7227)
github-actions
bot
added
bug
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #7447 +/- ##
==========================================
+ Coverage 90.59% 90.61% +0.01%
==========================================
Files 427 427
Lines 15202 15199 -3
==========================================
Hits 13773 13773
+ Misses 1429 1426 -3
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@Mr-Technician requesting a review for this pull request, thank you. Please let me know if there are any changes that need to be made, and apologies if there is anything incorrect in the pull request, this is the first one that I have made. |
Member
|
@vorsprungdev I tweaked the wording slightly. |
Mr-Technician
approved these changes
Aug 31, 2023
Member
|
@Mr-Technician this can be merged? |
Member
Yes, I was giving him a chance to comment if he wanted to. |
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
…intention (MudBlazor#7227) (MudBlazor#7447) * Update MudFileUpload.razor.cs MudFileUpload: Updated summary for MaximumFileCount to better convey its behaviour when AppendMultipleFiles="true" (MudBlazor#7227) * Update MudFileUpload.razor.cs --------- Co-authored-by: Riley Nielsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the summary for MaximumFileCount in the MudFileUpload component. The new summary better conveys the intention of the property when AppendMultipleFiles="true", which is that it only limits the number of files that can be selected in a file dialog instance, and does not limit the total number of files that may be uploaded by the component.
Resolves #7227
How Has This Been Tested?
Commit was tested by building and running MudBlazor.Docs.Server and confirming that the changes made are visible in the API docs for MudFileUpload. No new unit tests have been created.
Types of changes
Checklist:
dev).