Skip to content

Buttons: Add nullable annotation.#7427

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:button_nullable
Aug 26, 2023
Merged

Buttons: Add nullable annotation.#7427
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:button_nullable

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Aug 26, 2023

Description

Part of this issue #6535

How Has This Been Tested?

No tests required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@ScarletKuro ScarletKuro mentioned this pull request Aug 26, 2023
Open
94 tasks
@ScarletKuro ScarletKuro added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library and removed PR: needs review labels Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (2b6bd44) 90.58% compared to head (f7e87a6) 90.59%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7427      +/-   ##
==========================================
+ Coverage   90.58%   90.59%   +0.01%     
==========================================
  Files         427      427              
  Lines       15188    15188              
==========================================
+ Hits        13758    13760       +2     
+ Misses       1430     1428       -2
Files Changed Coverage Δ
...zor/Components/Button/MudToggleIconButton.razor.cs 100.00% <ø> (ø)
src/MudBlazor/Components/Button/MudButton.razor 100.00% <100.00%> (ø)
src/MudBlazor/Components/Button/MudButton.razor.cs 100.00% <100.00%> (ø)
src/MudBlazor/Components/Button/MudFab.razor.cs 100.00% <100.00%> (ø)
...rc/MudBlazor/Components/Button/MudIconButton.razor 100.00% <100.00%> (ø)
...MudBlazor/Components/Button/MudIconButton.razor.cs 100.00% <100.00%> (ø)
...Blazor/Components/Button/MudToggleIconButton.razor 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit e199903 into MudBlazor:dev Aug 26, 2023
@ScarletKuro ScarletKuro deleted the button_nullable branch August 26, 2023 21:36
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@ScarletKuro @ilovepilav
Buttons: Add nullable annotation. (MudBlazor#7427)
6711b9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScarletKuro