MudChip, MudAvatar: Fix visual bug#7406
Conversation
github-actions
bot
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #7406 +/- ##
==========================================
+ Coverage 90.59% 90.60% +0.01%
==========================================
Files 427 427
Lines 15176 15196 +20
==========================================
+ Hits 13748 13768 +20
Misses 1428 1428
☔ View full report in Codecov by Sentry. |
…st initials of a real person, Updated MudChip icon size and spacing for the large chip, added Avatar example into the docs (MudBlazor#7392)
henon
changed the title
|
@Mr-Technician @JonBunator, could you also read this #7392 (comment) and comment on the background color moment? |
|
I would add a new color property to our variables. There is no reason not to. |
…ables for colors for the default chip (MudBlazor#7392)
|
I added two new colors for the default color and the hover and also updated the dark palette for those colors as well. @Mr-Technician Before After The hover is also softer, but it is now according to the docs. |
|
Should be this converted to a normal PR? The changes look correct. |
|
I asked @Garderoben to give the final approval of the visual changes. He should get to it on Sunday |
* MudChip: Fixes for Avatar and minor visuals (MudBlazor#7392) * Added appropriate test for the new render fragment * MudChip: Updated font sizes for MudAvatar to accommodate first and last initials of a real person, Updated MudChip icon size and spacing for the large chip, added Avatar example into the docs (MudBlazor#7392) * MudChip: Adjusted margin end as is in material documentation (MudBlazor#7392) * MudAvatar, MudChip: updated obsolete XML descriptions, added new variables for colors for the default chip (MudBlazor#7392) * MudAvatar, MudChip: Updated tests for ThemeProvider (MudBlazor#7392)
5 participants
Description
Adds the possibility to render avatar as a render fragment. Also addresses minor visual bug fixes with the MudAvatar and MudChip.
I know this wasn't the scope of this issue, but I updated the font size for the avatars so they can accommodate first and last name initials instead of just one char. This extends just a little to the functionality.
This is my before and after with the chips.
I also updated the Large chips icon size and its margins. Lastly, I added example code for the new AvatarContent render fragment into the docs.
The medium MudChip should now have spacings such as is displayed in this image from Material documentation.
I know MudChip still needs some more polishing, but for now, I'm satisfied. I'll be waiting on the color variable from the core team, and then I'll mark the PR ready for review.
Fixes #7392
How Has This Been Tested?
I'll do all the necessary tests.
Types of changes
Checklist:
dev).