Skip to content

MudTimeline: Make horizontal layout responsive#7402

Merged
henon merged 1 commit intoMudBlazor:devfrom
BEEG3R:feature/responsive-horizontal-timeline
Aug 22, 2023
Merged

MudTimeline: Make horizontal layout responsive#7402
henon merged 1 commit intoMudBlazor:devfrom
BEEG3R:feature/responsive-horizontal-timeline

Conversation

@BEEG3R
Copy link
Contributor

@BEEG3R BEEG3R commented Aug 21, 2023

Description

Added a min-width property to the mud-timeline-item CSS class nested within the mud-timeline-horizontal class, both defined in the SASS partial _timeline.scss. This allows the horizontal timeline to be responsive, and prevents overflow on any screen size down to ~325px wide.
Resolves #7368

How Has This Been Tested?

This was visually tested using the MudBlazor.UnitTests.Viewer project. No new tests were created.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Recording 2023-08-21 at 17 58 44

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

By simply adding a min-width property to the mud-timeline-item nested within the mud-timeline-horizontal style, I was able to prevent the items from overflowing down to screen sizes of about 325px wide.
@ScarletKuro
Copy link
Member

Hi. Thanks for PR.
Does this addresses this issue #7368? If yes, please add it to the issue with
"Resolves: #7368" as separate line

@ScarletKuro ScarletKuro requested a review from henon August 21, 2023 22:26
@BEEG3R
Copy link
Contributor Author

BEEG3R commented Aug 21, 2023

Updated the PR to include the issue it resolves.

@henon henon changed the title Updated horizontal MudTimeline to be responsive MudTimeline: Make horizontal TL responsive Aug 22, 2023
@henon henon changed the title MudTimeline: Make horizontal TL responsive MudTimeline: Make horizontal layout responsive Aug 22, 2023
@henon henon merged commit 6627646 into MudBlazor:dev Aug 22, 2023
@henon
Copy link
Contributor

henon commented Aug 22, 2023

Wow, simple fix. Thanks!

@ScarletKuro ScarletKuro added bug Unexpected behavior or functionality not working as intended and removed PR: needs review labels Aug 22, 2023
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
…Blazor#7402)

By simply adding a min-width property to the mud-timeline-item nested within the mud-timeline-horizontal style, I was able to prevent the items from overflowing down to screen sizes of about 325px wide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mudtimeline is not responsive

3 participants