Support negative y axes in line and bar charts#7401
Merged
henon merged 2 commits intoMudBlazor:devfrom Aug 22, 2023
chausner:charts-negative-axes
Merged
Support negative y axes in line and bar charts#7401henon merged 2 commits intoMudBlazor:devfrom chausner:charts-negative-axes
henon merged 2 commits intoMudBlazor:devfrom
chausner:charts-negative-axes
Conversation
github-actions
bot
added
enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #7401 +/- ##
==========================================
- Coverage 90.59% 90.58% -0.01%
==========================================
Files 427 427
Lines 15176 15188 +12
==========================================
+ Hits 13748 13758 +10
- Misses 1428 1430 +2
☔ View full report in Codecov by Sentry. |
Member
|
Could you add a image / gif that demonstrates how it looks on the chart? |
Contributor
Author
Sure, I have added screenshots in the original post. |
Contributor
|
Thanks! |
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
* Support negative y axes in line and bar charts * Convert tab to spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This extends the line chart and bar chart implementations to support negative y values.
Fixes #6810
How Has This Been Tested?
The existing unit tests for line and bar chart have been updated to include negative values.
Further, the sample charts on the unit test viewer have been updated to include negative values, and the resulting charts have been tested visually.
Types of changes
Before
After
Checklist:
dev).