Skip to content

MudTable: Fix the shifting of striped rows when loading#7384

Merged
henon merged 3 commits intoMudBlazor:devfrom
BieleckiLtd:fix/table-striped-loading
Aug 19, 2023
Merged

MudTable: Fix the shifting of striped rows when loading#7384
henon merged 3 commits intoMudBlazor:devfrom
BieleckiLtd:fix/table-striped-loading

Conversation

@BieleckiLtd
Copy link
Contributor

@BieleckiLtd BieleckiLtd commented Aug 19, 2023

Based on the work by @aldakloran; The original PR #4628 appears to have gone stale.

  • brought up to speed with current dev
  • added unit test
  • minor perf improvements

Description

Fixes #3103

How Has This Been Tested?

visually + unit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
2023-08-19_13-49-00.mp4

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Aug 19, 2023
@ScarletKuro ScarletKuro requested a review from henon August 19, 2023 13:00
Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BieleckiLtd BieleckiLtd changed the title Fix/table striped loading MudTable: Fixed the shifting of striped rows when loading is visible. Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d79473c) 90.58% compared to head (1e4629b) 90.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #7384   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         427      427           
  Lines       15173    15174    +1     
=======================================
+ Hits        13744    13745    +1     
  Misses       1429     1429           
Files Changed Coverage Δ
src/MudBlazor/Components/Table/MudTable.razor 97.12% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Aug 19, 2023

If this will be considered to be merged, please add the #4628 PR author as co-author during merge.

@henon henon changed the title MudTable: Fixed the shifting of striped rows when loading is visible. MudTable: Fix the shifting of striped rows when loading Aug 19, 2023
@henon henon merged commit b2d00e4 into MudBlazor:dev Aug 19, 2023
@henon
Copy link
Contributor

henon commented Aug 19, 2023

Thanks @aldakloran and @BieleckiLtd

ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
* move loading section to table header insted of body

* add loading bar also if header doesn't exist

* Added unit test; minor perf improvements.

---------

Co-authored-by: aldakloran <[email protected]>
Co-authored-by: Michał Smoliński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudTable loading indicator shifts striped rows when paginating

4 participants