Skip to content

TestViewer: Better search and other minor tweaks#7353

Merged
henon merged 7 commits intoMudBlazor:devfrom
chausner:unittest-viewer-tweaks
Oct 15, 2023
Merged

TestViewer: Better search and other minor tweaks#7353
henon merged 7 commits intoMudBlazor:devfrom
chausner:unittest-viewer-tweaks

Conversation

@chausner
Copy link
Contributor

@chausner chausner commented Aug 14, 2023 •
edited
Loading

Description

This applies a number of minor improvements and tweaks to the unit tests viewer:

  • Made the drawer width a bit larger so that most of the test component names are no longer cut off
  • Use MudNavMenu for the list, it looks more polished than the raw MudList
  • Change the search behavior to also find test components by substrings, e.g. typing "chart" will now also find "LineChartWithBigValuesTests". Before it would search by prefix only.
  • A couple of other minor tweaks/refactorings.

How Has This Been Tested?

Tested all changes manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (4cf042d) 90.62% compared to head (7400ab6) 90.63%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #7353   +/-   ##
=======================================
  Coverage   90.62%   90.63%           
=======================================
  Files         427      427           
  Lines       15174    15182    +8     
=======================================
+ Hits        13752    13760    +8     
  Misses       1422     1422

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chausner
Copy link
Contributor Author

chausner commented Oct 14, 2023

@henon Would be nice to have someone review these changes. :)

@henon henon changed the title Various minor tweaks and improvements in unit tests viewer TestViewer: Better search and other minor tweaks Oct 15, 2023
@henon henon merged commit b2064f6 into MudBlazor:dev Oct 15, 2023
@henon
Copy link
Contributor

henon commented Oct 15, 2023

LGTM, thanks a lot.

@henon henon removed bug Unexpected behavior or functionality not working as intended PR: needs review labels Oct 15, 2023
@chausner chausner deleted the unittest-viewer-tweaks branch October 15, 2023 13:40
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@chausner @ilovepilav
TestViewer: Better search and other minor tweaks (MudBlazor#7353)
85aa979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chausner @henon