Skip to content

MudSlider: Center track tick labels#7302

Merged
Garderoben merged 2 commits intoMudBlazor:devfrom
DennisOstertag:fix/MudSlider-tick-marks-not-centered
Apr 16, 2024
Merged

MudSlider: Center track tick labels#7302
Garderoben merged 2 commits intoMudBlazor:devfrom
DennisOstertag:fix/MudSlider-tick-marks-not-centered

Conversation

@DennisOstertag
Copy link
Contributor

@DennisOstertag DennisOstertag commented Aug 4, 2023 •
edited
Loading

Description

The labels are not centered correctly, see #7274. This will center them.

How Has This Been Tested?

Visually only

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Aug 4, 2023
@DennisOstertag
Merge branch 'dev' of https://github.com/DennisOstertag/MudBlazor int…
29f8df7 
…o fix/MudSlider-tick-marks-not-centered

# Conflicts:
#	src/MudBlazor/Styles/components/_slider.scss
@codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (851eba0) to head (29f8df7).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7302      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.02%     
==========================================
  Files         411      411              
  Lines       11832    11832              
  Branches     2349     2349              
==========================================
+ Hits        10590    10593       +3     
+ Misses        718      717       -1     
+ Partials      524      522       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DennisOstertag
Copy link
Contributor Author

DennisOstertag commented Apr 2, 2024

branch updated, fixed conflicts and tested this is still valid.

@Garderoben
Copy link
Member

Garderoben commented Apr 14, 2024

@DennisOstertag Before and after picture please.
And i guess you checked all examples, nothing else breaks from this?

@DennisOstertag
Copy link
Contributor Author

DennisOstertag commented Apr 15, 2024

Hi, thanks for the look at it @Garderoben .
here is a screenshot of before and after:
MudBlazor-Center-Tick-Labels

and here is link if you wanna try it out yourself
https://try.mudblazor.com/snippet/mEcdYBxuVToqvaqs

Regarding your question:
As this is just an adjustment in the class of the slider tick labels, it should not be used anywhere else.

@Garderoben Garderoben merged commit ebad5f6 into MudBlazor:dev Apr 16, 2024
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@DennisOstertag @biegehydra
MudSlider: Center track tick labels (MudBlazor#7302)
47359bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garderoben Garderoben Garderoben approved these changes

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DennisOstertag @Garderoben