Codecov Report

Patch coverage: 80.00% and project coverage change: -0.11% ⚠️

Comparison is base (8e9fcd5) 90.71% compared to head (2f3255e) 90.60%.
Report is 37 commits behind head on dev.

❗ Current head 2f3255e differs from pull request most recent head fdf1a6e. Consider uploading reports for the commit fdf1a6e to get more accurate results

@@            Coverage Diff             @@
##              dev    #7174      +/-   ##
==========================================
- Coverage   90.71%   90.60%   -0.11%     
==========================================
  Files         426      427       +1     
  Lines       15098    15162      +64     
==========================================
+ Hits        13696    13738      +42     
- Misses       1402     1424      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi there, we discussed this in the team and we can see the use-case of a selection step for minute selection especially for intervals of say 5 minutes. However, the inanimous opinion is that the visualization of the clock should not change, no matter what the step is. By not touching the visualization this opens up the possibility to do away with the enum which we also don't feel like a good design choice (I am sure if we add this feature at some point in time somebody will need a time step that is not in the enum). So in essence, we'd be willing to add this feature if you make the following changes:

• Make the parameter of type int and call it MinuteSelectionStep with default value 1.
• When the user selects, round to the next minute of MinuteSelectionStep % 60 (modulo), so no matter what value is set (i.e. 65 will result in an effective step of 5). This of course allows steps that make no sense (like 17) but that is up to the user.

What do you say?

Those changes sound good to me, I'll make the adjustments soon.

I have completed the requested changes, it should be ready to go.

Can you record a GIF using ScreenToGif and post here please? Thanks a lot

@ScarletKuro I see the testrunner crashed. There is an updated sdk that fixes some core dump issues I'll update it although I guess rerunning this PR will work

Thank you @Zingabopp !