Codecov Report

Patch coverage: 53.84% and project coverage change: +0.12 🎉

Comparison is base (49e627a) 90.63% compared to head (ed2db51) 90.76%.

@@            Coverage Diff             @@
##              dev    #6627      +/-   ##
==========================================
+ Coverage   90.63%   90.76%   +0.12%     
==========================================
  Files         399      399              
  Lines       13587    13582       -5     
==========================================
+ Hits        12315    12328      +13     
+ Misses       1272     1254      -18     

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henon there is one small annoyance with the filter when using ColumnFilterMenu that goes like this open filter menu -> input value -> apply a filter -> server called -> open filter menu -> remove value -> grid refreshes with all the items without calling server

I see now that you marked it as draft.

I'm working on it right now, I'll expand the tests when I fix it.

The current solution seems acceptable to me, but I'm concerned about the number of InvokeServerLoadFunc / ReloadServerData calls spreader everywhere in the code , which is quite high. It would be great if we could improve the design in the future and introduce something like IMudDataGridChangedNotification (args type of change filter / sort / pagination etc). This would trigger data reload in a single place.

@ScarletKuro you're absolutely right, it's repetitive and error prone and it will only get more difficult to debug.

Fixed it, silly multiple enumerations mistakes in tests. @henon Ready for review :)

silly multiple enumerations mistakes

This is also concerning, and I noticed this problem before as well, there are a lot of multiple enumerations in some places, and there are places where IEnumerable doesn't make sense. But the problem is that a lot of such places are public API.

silly multiple enumerations mistakes

This is also concerning, and I noticed this problem before as well, there are a lot of multiple enumerations in some places, and there are places where IEnumerable doesn't make sense. But the problem is that a lot of such places are public API.

Exactly, ReSharper or Rider would help greatly with this issue although they don't catch'em all.

I will tag @tjscience as well.

@henon if I am not mistaken this is now ready.

Looks good. Thanks!