MudDataGrid: Allow to plug any filter type handler#6626
Draft
ScarletKuro wants to merge 8 commits intoMudBlazor:devfrom
Draft
MudDataGrid: Allow to plug any filter type handler#6626ScarletKuro wants to merge 8 commits intoMudBlazor:devfrom
ScarletKuro wants to merge 8 commits intoMudBlazor:devfrom
Conversation
Member
Author
|
This solution is still in the early stages of development and requires further polishing, but would it address the issue you raised @sjd2021? FYI, @henon and @tjscience, I would appreciate your overall thoughts on this concept / idea whatever we need such flexibility. |
|
I'd be happy with the bare minimum, but yes this would work as well.
…On Tue, Apr 11, 2023, 8:46 AM Artyom M. ***@***.***> wrote:
This solution is still in the early stages of development and requires
further polishing, but would it address the issue you raised @sjd2021
<https://github.com/sjd2021>?
FYI, @henon <https://github.com/henon> and @tjscience
<https://github.com/tjscience>, I would appreciate your overall thoughts
on this concept / idea whatever we need such flexibility.
—
Reply to this email directly, view it on GitHub
<#6626 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUA5RNQOKOSKTUPSZCH5XETXAVHDLANCNFSM6AAAAAAW2GQL7Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (85.45%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #6626 +/- ##
==========================================
+ Coverage 90.62% 90.64% +0.02%
==========================================
Files 399 407 +8
Lines 13584 13625 +41
==========================================
+ Hits 12310 12350 +40
- Misses 1274 1275 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
2 tasks
2 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an early prototype for an idea that can be found here: #6049 (comment). Essentially, it allows to wire up any type to the filter. For example, if there is a lack of support for
TimeOnly, one can implement their ownFilterTypeBaseand add the corresponding UI part to handle it.Initially, I had a simple idea:
However, I encountered the issue of an external render fragment interfering with the render lifecycle and throwing an error:
System.InvalidOperationException: 'The render handle is not yet assigned.'I attempted three prototypes before settling on the current implementation, which uses
DynamicComponentand ensures that the render lifecycle works correctly. My previous prototypes required "hacks" that probably wouldn't be accepted, which is why I decided to go with the current solution.How Has This Been Tested?
Unit test + new unit tests(incoming)
Types of changes
Checklist:
dev).