MudDataGrid: Fix ExpandAllGroups/CollapseAllGroups skipping some groups (#6591)#6592
Conversation
github-actions
bot
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #6592 +/- ##
==========================================
- Coverage 91.42% 91.42% -0.01%
==========================================
Files 398 398
Lines 14959 14954 -5
==========================================
- Hits 13677 13671 -6
- Misses 1282 1283 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ghost
mentioned this pull request
8 tasks
Contributor
|
Ideally the fix is covered by a test that fails without it and stops failing with the fix. |
Author
|
Alright, I'll see what I can do when I get my hands on my computer this evening. |
henon
changed the title
Contributor
|
Thanks a lot! |
ghost
deleted the
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
…ps (MudBlazor#6591) (MudBlazor#6592) * MudDataGrid: Fixes ExpandAllGroups/CollapseAllGroups skipping some groups (MudBlazor#6591) * Add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #6591
How Has This Been Tested?
visually
Types of changes
Checklist:
dev).