MudDatagrid: Fix grouping to work with filtered items cache.#6557
Merged
henon merged 1 commit intoMudBlazor:devfrom Mar 30, 2023
Merged
MudDatagrid: Fix grouping to work with filtered items cache.#6557henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
6 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #6557 +/- ##
=======================================
Coverage 91.46% 91.47%
=======================================
Files 393 393
Lines 14876 14877 +1
=======================================
+ Hits 13607 13608 +1
Misses 1269 1269
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
|
@ScarletKuro FYI |
Contributor
|
@adameste Thank you very much for the quick fix. |
ScarletKuro
pushed a commit
to ScarletKuro/MudBlazor
that referenced
this pull request
Apr 4, 2023
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix datagrid grouping breaked by previous PR #6495.
GroupDefinitions were initialized with previous lazy-evaluated linq query and thus updated with every render.
With cache they get a list, which stays the same and groups don't update properly.
Fixed it by updating groupings after new items cache is created, added parameter to not update component state - that would cause infinite rendering loop.
Maybe a better solution involving more work is possible (pass function to GroupDefinition? possibly slower). This should work just fine.
How Has This Been Tested?
Types of changes
Checklist:
dev).