IconsPage: remove fixed height to fix footer position (#6532)#6542
Merged
henon merged 1 commit intoMudBlazor:devfrom Apr 1, 2023
Merged
Conversation
The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.
github-actions
bot
added
bug
2 tasks
Member
henon
added
docs
Contributor
|
Thanks Kevin! |
ScarletKuro
pushed a commit
to ScarletKuro/MudBlazor
that referenced
this pull request
Apr 4, 2023
The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello this is my first contribution to this project. I hope i made everything correct. Otherwise let me know.
This Pull Request Closes #6532 and closes #5493
The container had a fixed height of 34000px, which moved the footer to that position. Depending on the number of icons, the footer covered the icons or for the custom icons (less icons) the page was unnecessary large.
How Has This Been Tested?
Visually
Types of changes
Before:
Material Icons:
Custom Icons:
After:
Material Icons:
Custom Icons:
Checklist:
dev).