Skip to content

MudAppBar: Add nullable annotation#6540

Merged
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:apprbar_nullable
Mar 28, 2023
Merged

MudAppBar: Add nullable annotation#6540
henon merged 1 commit intoMudBlazor:devfrom
ScarletKuro:apprbar_nullable

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Mar 27, 2023

Description

Part of this issue #6535

Currently no pull requests to AppBar.

How Has This Been Tested?

No tests required in case of MudAppBar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro mentioned this pull request Mar 27, 2023
Open
94 tasks
@ScarletKuro
Copy link
Member Author

ScarletKuro commented Mar 27, 2023

Not related. but side information.
I noticed that CssBuilder.AddClass doesn't check if string is null or empty, which leads to additional allocation since it appends " " to the string buffer.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e23518e) 91.17% compared to head (e7dd080) 91.17%.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #6540   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files         392      392           
  Lines       14836    14836           
=======================================
  Hits        13527    13527           
  Misses       1309     1309
Impacted Files Coverage Δ
src/MudBlazor/Components/AppBar/MudAppBar.razor.cs 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro
Copy link
Member Author

ScarletKuro commented Mar 27, 2023

@henon

@henon henon merged commit b867d16 into MudBlazor:dev Mar 28, 2023
@henon henon added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library and removed PR: needs review labels Mar 28, 2023
@ScarletKuro ScarletKuro deleted the apprbar_nullable branch April 1, 2023 20:00
@renovate renovate bot mentioned this pull request Sep 14, 2023
Closed
1 task
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@ScarletKuro @ilovepilav
MudAppBar: Add nullable annotation (MudBlazor#6540)
6f583a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScarletKuro @henon