BaseInput: Validation should not run on blur when ReadOnly = true.#6518
Merged
Mr-Technician merged 1 commit intoMudBlazor:devfrom Mar 23, 2023
Merged
Conversation
Mr-Technician
added
the
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #6518 +/- ##
==========================================
+ Coverage 91.16% 91.17% +0.01%
==========================================
Files 388 392 +4
Lines 14790 14836 +46
==========================================
+ Hits 13483 13527 +44
- Misses 1307 1309 +2
... and 30 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
|
Makes sense. What about |
henon
approved these changes
Mar 23, 2023
Member
Author
I'll double-check but I don't believe it's possible to trigger onblur when an input is disabled. That's the big difference between |
6 tasks
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, a readonly field would still run validation on blur. This PR prevents this behavior:
https://try.mudblazor.com/snippet/wacnYnQdporidlIP
How Has This Been Tested?
Unit
Types of changes
Checklist:
dev).