MudDataGrid: Fix missing content/error in Cell edit mode for HierarchyColumn (#6024)#6441
Merged
henon merged 1 commit intoMudBlazor:devfrom Mar 13, 2023
Merged
MudDataGrid: Fix missing content/error in Cell edit mode for HierarchyColumn (#6024)#6441henon merged 1 commit intoMudBlazor:devfrom
henon merged 1 commit intoMudBlazor:devfrom
Conversation
…xing the missing MudIconButton when MudDataGrid is not ReadOnly, and its Edit Mode is equals to Cell. Added MudSwtich to DetailRowExample to test it visually.
github-actions
bot
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #6441 +/- ##
==========================================
+ Coverage 91.15% 91.16% +0.01%
==========================================
Files 388 388
Lines 14776 14785 +9
==========================================
+ Hits 13469 13479 +10
+ Misses 1307 1306 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
Looks good @tjscience, you concur? |
henon
approved these changes
Mar 13, 2023
Contributor
|
Yes, looks good. |
henon
changed the title
henon
changed the title
Contributor
|
Thank you Henrique! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes DataGrid HierarchyColumn missing content/arrow in Cell edit mode #6024 ;
Changed Inner TemplateColumn of the HierarchyColumn to be not editable, setting
IsEditable="false", because the rendering process was trying to render column's EditTemplate, and it's null (and should continue to be). By this change, MudDataGrid rendering process will look just for the CellTemplate, and will render column's MudIconButton (arrows);Updated DataGridDetailRowExample.razor to test the behavior.
How Has This Been Tested?
Visually tests only, since it's relative simple.
Types of changes
Checklist:
dev).