MudDialog: Change OnBackdropClick Action to EventCallback by BieleckiLtd · Pull Request #6151 · MudBlazor/MudBlazor

BieleckiLtd · 2023-01-15T22:44:08Z

Description

Swapped Action to EventCallback<MouseEventArgs> delegate, which is preferred as an OnClick handler. Sync methods are still supported, i.e. user can still do this for example:

<MudDialog OnBackdropClick="Cancel"/>

void Cancel()
{
    isVisible = false;
}

But after this pr user can also do this:

<MudDialog OnBackdropClick="CancelAsync"/>

async Task CancelAsync()
{
    await myService.CancelAsync();
    isVisible = false;
}

How Has This Been Tested?

existing unit tests

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

The PR is submitted to the correct branch (dev).
My code follows the code style of this project.
I've added relevant tests.

…Closes #6146

codecov · 2023-01-16T11:28:20Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.31 🎉

Comparison is base (b6e7600) 91.16% compared to head (3f28f37) 91.48%.

❗ Current head 3f28f37 differs from pull request most recent head 4e26fa9. Consider uploading reports for the commit 4e26fa9 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #6151      +/-   ##
==========================================
+ Coverage   91.16%   91.48%   +0.31%     
==========================================
  Files         388      383       -5     
  Lines       14794    15062     +268     
==========================================
+ Hits        13487    13779     +292     
+ Misses       1307     1283      -24

Impacted Files	Coverage Δ
src/MudBlazor/Components/Dialog/MudDialog.razor.cs	`94.73% <ø> (-0.10%)`	⬇️
...udBlazor/Components/Dialog/MudDialogInstance.razor	`100.00% <ø> (ø)`
...lazor/Components/Dialog/MudDialogInstance.razor.cs	`84.66% <100.00%> (+1.71%)`	⬆️

... and 64 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

henon · 2023-03-14T09:12:02Z

Is this a breaking change?

BieleckiLtd · 2023-03-15T00:48:07Z

Is this a breaking change?

No, existing tests remained unchanged, and they still pass.

Please note 3f28f37 in my PR was created to resolve conflict with #6083 however I believe that PR was reverted since.

henon · 2023-03-15T08:22:35Z

I resolved the conflicts.

henon · 2023-03-15T08:37:56Z

I guess I messed it up :(

Method renamed to be HandleBackgroundClickAsync

BieleckiLtd · 2023-03-16T12:55:24Z

Sorted :)

src/MudBlazor/Components/Dialog/MudDialogInstance.razor.cs

Added null check in case _dialog is null.

henon · 2023-03-16T15:52:32Z

Awesome. Thanks!

…6151) * Changed MudDialog's OnBackdropClick delegate to support async methods. Closes MudBlazor#6146 --------- Co-authored-by: Meinrad Recheis <[email protected]>

* Docs: MudRadioGroup: vertical align (MudBlazor#5597) * New Component: MudFileUpload (MudBlazor#5488) * Revert "MudDataGrid: Add onmousedown callback parameter on DataGrid row (MudBlazor#5383)" This reverts commit 90b1076. * MudCollapse: Better solution to non-rendering event (Add EventUtil) (MudBlazor#5661) Co-authored-by: Meinrad Recheis <[email protected]> * Docs: Corrections to pointer events section (MudBlazor#5663) * Build(deps): Bump Microsoft.NET.Test.Sdk from 17.3.2 to 17.4.0 in /src (MudBlazor#5679) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.2 to 17.4.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.3.2...v17.4.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Picker: Improve test coverage and fix ColorPicker bug (MudBlazor#5680) * Tests: Fix some missing awaits (MudBlazor#5684) * Theming: Easier customization of dark mode (MudBlazor#5676) * MudDataGrid: Add FormFieldChanged event (MudBlazor#5689) * MudNavLink: Allow custom ActiveClass (MudBlazor#5619) * Build: Use net6 for local build (MudBlazor#5690) * Update to 6.0.18 * Snackbar: Testing a potential fix MudBlazor#5695 * Revert "Snackbar: Testing a potential fix MudBlazor#5695". We know now that it is a trimming issue This reverts commit a22a487. * Snackbar: Fix accidental API break by PR MudBlazor#5310 (MudBlazor#5701) Snackbar: Fix API break MudBlazor#5696 by PR MudBlazor#5310 * Snackbar: Fix break due to trimming of SnackbarMessageType (MudBlazor#5711) * v6.0.19-dev1 * Build: add net7 library (multi-targeting) (MudBlazor#5713) * v6.0.19-dev2 (net7 support) * Divider: Fix inconsistent thickness (MudBlazor#5490, MudBlazor#5491) * Tests: Fix locale issue due to date literal (MudBlazor#5729) * vv6.0.19-dev3 (net7 support) * MudDataGrid: Add GroupClassFunc and GroupStyleFunc (MudBlazor#5560) * MudDataGrid: Fix missing DataGrid reference in FilterDefinition (MudBlazor#5498) * v6.1.0 (net7 support) (MudBlazor#5732) * Build: Fix staging publish * MudMenu: Fix MouseEventArgs on net7 on BSS (MudBlazor#5738) * v6.1.1 * Build: Add nuget publish github action * Build: Add manual nuget publish * Build: Fix manual tag version * Build: Fix syntax error in nuget publish * Build: Fix Environment variable test * v6.1.2 (MudBlazor#5751) * Build: Dont publish nuget release * Build(deps): Bump ReportGenerator from 5.1.10 to 5.1.11 in /src (MudBlazor#5743) Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.1.10 to 5.1.11. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v5.1.10...v5.1.11) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump Blazored.LocalStorage from 4.2.0 to 4.3.0 in /src (MudBlazor#5746) Bumps [Blazored.LocalStorage](https://github.com/Blazored/LocalStorage) from 4.2.0 to 4.3.0. - [Release notes](https://github.com/Blazored/LocalStorage/releases) - [Commits](Blazored/LocalStorage@v4.2.0...v4.3.0) --- updated-dependencies: - dependency-name: Blazored.LocalStorage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build: Fix code coverage due to SDK 7.0.100 bug * Changed dispose/event removal order from: (MudBlazor#5706) * Docs: Update README to reflect support for .NET 7 (MudBlazor#5767) * MudLink: Add OnClick parameter (MudBlazor#1518) (MudBlazor#5785) * Charts: Make Legend Clickable (MudBlazor#5484) * MudColorPicker: Fix MaxLength on HEX TextField for transparent colors (MudBlazor#5582) Co-authored-by: David Griesser <[email protected]> * ScrollManager: Fix exceptions no JS environment (MudBlazor#5770) * MudDialog: Fix Dialog is null in IDialogReference (MudBlazor#5101) * Build: Use simpler syntax for internals visibility (MudBlazor#5797) * Update CONTRIBUTING.md (MudBlazor#5799) * Build(deps): Bump FluentValidation from 11.2.2 to 11.3.0 in /src (MudBlazor#5803) Bumps [FluentValidation](https://github.com/JeremySkinner/fluentvalidation) from 11.2.2 to 11.3.0. - [Release notes](https://github.com/JeremySkinner/fluentvalidation/releases) - [Changelog](https://github.com/FluentValidation/FluentValidation/blob/main/Changelog.txt) - [Commits](FluentValidation/FluentValidation@11.2.2...11.3.0) --- updated-dependencies: - dependency-name: FluentValidation dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump ReportGenerator from 5.1.11 to 5.1.12 in /src (MudBlazor#5806) Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.1.11 to 5.1.12. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v5.1.11...v5.1.12) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump NUnit3TestAdapter from 4.3.0 to 4.3.1 in /src (MudBlazor#5807) Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases) - [Commits](nunit/nunit3-vs-adapter@V4.3.0...V4.3.1) --- updated-dependencies: - dependency-name: NUnit3TestAdapter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump bunit from 1.11.7 to 1.12.6 in /src (MudBlazor#5804) Bumps [bunit](https://github.com/bUnit-dev/bUnit) from 1.11.7 to 1.12.6. - [Release notes](https://github.com/bUnit-dev/bUnit/releases) - [Changelog](https://github.com/bUnit-dev/bUnit/blob/main/CHANGELOG.md) - [Commits](bUnit-dev/bUnit@v1.11.7...v1.12.6) --- updated-dependencies: - dependency-name: bunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Tests: Fix test after bUnit update (MudBlazor#5808) * Fix ResizeBasedService trim warning (MudBlazor#5809) * Build: Fix static assets need 2 builds to publish (MudBlazor#5801) * Build: Fix static assets need 2 builds to publish * Build: deploy-nuget fixes * Build: Update secrets token for slot swap * Remove unused code in ElementReferenceExtensions (MudBlazor#5810) * Revert "Build: Fix static assets need 2 builds to publish (MudBlazor#5801)" (MudBlazor#5817) This reverts commit 98068aa. * Build: Fix static assets need 2 builds to publish (MudBlazor#5818)(MudBlazor#5801) (MudBlazor#5818) * MudCarousel: Fix swipe direction for next/previous in rtl (MudBlazor#5811) * MudRadio: Change the default value of the ContentPlacement. (MudBlazor#5813) * Docs: Update index statistics (MudBlazor#5835) * MudTable: Fix inconsistent row border thickness (MudBlazor#5822, MudBlazor#5823) * Table: Fix inconsistent border thickness * Remove redundant (default) lines border-collapse: separate; Co-authored-by: Dennis Mlinaric <[email protected]> * Tests/Components: Remove unnecessary Console.WriteLine (MudBlazor#5836) * TreeView: Add Public Select Method and Disable Text Selection When ExpandOnDoubleClick is true (MudBlazor#5856) * MudTable: Fixed table grouping item selection issue (MudBlazor#5759) (MudBlazor#5760) * Build(deps): Bump FluentValidation from 11.3.0 to 11.4.0 in /src (MudBlazor#5866) Bumps [FluentValidation](https://github.com/JeremySkinner/fluentvalidation) from 11.3.0 to 11.4.0. - [Release notes](https://github.com/JeremySkinner/fluentvalidation/releases) - [Changelog](https://github.com/FluentValidation/FluentValidation/blob/main/Changelog.txt) - [Commits](FluentValidation/FluentValidation@11.3.0...11.4.0) --- updated-dependencies: - dependency-name: FluentValidation dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add a docstring in BunitTest * Tests: Autocomplete loading finishes too quickly to test progress (MudBlazor#5872) * Chip: Fix pointer cursor if href set (MudBlazor#5871) * Chip: Fix pointer cursor if href set * Classname property back to lambda * MudBaseButton: Make OnClickHandler virtual (MudBlazor#5879) MudBlazor#5878 * MudFileUpload: Maximum file count integrated as a parameter (MudBlazor#5861) Co-authored-by: Florian <[email protected]> * Build: Automate release notes (MudBlazor#5881) * Build: Update exclude labels for release notes * FileUpload: Cleanup MaximumFileCount tests and update docs. (MudBlazor#5882) * MudTooltip: Activation via Hover, Focus or Click (MudBlazor#4647) * MudTimePicker: Fix TimePicker validation in MudForm (MudBlazor#5883) (MudBlazor#5884) * TreeView: Fix closing arrow transition (MudBlazor#5858) * Build: Update projects to net7 (MudBlazor#5873) * fixed typo referenced in MudBlazor#5889 (MudBlazor#5893) * Build: New workflows for release pipeline (MudBlazor#5899) * Build: Remove old workflow files * Build: Remove stray vscode settings file * Build: Fix website-version inputs * Build: Fix deploy-mudblazor worklflow * Build: Fix versioning parameter on release workflows * Build: Fix assembly version in nuget * Build: Fix snippets and API docs include * Build: Add action for mudblazor HEAD * Build(deps): Bump Moq from 4.18.2 to 4.18.3 in /src (MudBlazor#5909) Bumps [Moq](https://github.com/moq/moq4) from 4.18.2 to 4.18.3. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](devlooped/moq@v4.18.2...v4.18.3) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build: Add trymudblazor deploy on release * Build: Fix deploy-trymudblazor action * Build: Fix deploy-trymudblazor action * Build: Fix deploy-trymudblazor action * Build: Compile exclude needs `\` comparison * Build: Update workflow badge * Table: SelectedItem should fire regardless of EditTrigger setting (MudBlazor#5903) * Popover : Check popoverContentNode null before use (MudBlazor#5897) * Tests: Fix TimePicker validation test (MudBlazor#5924) * Tests: Fix IDialog interface so it can be Moqed (MudBlazor#5925) * Tests: Refactor to correct naming of TimePicker * MudSnackbar: Fix overflowing, long message (MudBlazor#3945) (MudBlazor#5929) * Docs: Add local development requirements (MudBlazor#5930) * Build: Don't deploy sites for pre-release packages (MudBlazor#5931) * MudDataGrid: Fixed the resizer handle staying visible (MudBlazor#5851) * MudDialog: Fix not aligned Toolbar buttons on Dialog header (MudBlazor#5497) (MudBlazor#5725) * MudDialog: Fix close button in RTL (MudBlazor#5951) * MudDataGrid: Fix the FilterHeaderCell visible when the Column is hidden (MudBlazor#5777) * Fix the filter header cell visible when the column is hidden * Moved the Column.Hidden check so the cell is not rendered only when the column is hidden * Moved the null check in the first line * Updated a test to ensure the filter row is rendered correctly even when a column is not filterable * MudDataGrid: ServerData initialization fix (MudBlazor#5635) * MudAlert: Fix CloseIcon color in Filled Variant (MudBlazor#5436) (MudBlazor#5449) * Select and Autocomplete: Add ListClass (MudBlazor#5402) * Add ListClass * Basic Unit Test * MudTreeViewItem: add CanExpand Property (MudBlazor#4093) (MudBlazor#4097) * MudTreeViewItem: changed summary of canExpand property of MudTreeViewItem (MudBlazor#5953) * MudProgress: Fixed border radius for rounded linear progress bar (MudBlazor#5963) * BreakpointService: IsMediaSize should will return true for Breakpoint.Always (MudBlazor#5898) * MudAutoComplete: Don't write to console for errors (MudBlazor#5970) * MudTable: Allow row-click without selecting checkbox when in multi-select mode (MudBlazor#5961) * Docs: Fix InvalidOperationException in "Record Type Support" docs example (MudBlazor#5978) * Build: Remove coverage workaround now SDK 7.0.1 is released * Build: Update Package versions to 7.0.1 * Docs: Fix GitHub dark mode logo * Build: Fix badge new shields io url * Build: Fix build badge markdown * Build: Add github log to build badge * Make Blazor Error UI message more legible (MudBlazor#5996) * Fix table CSS when subtales appear in the last row. (MudBlazor#5992) * MudTable: Added OverscanCount as a parameter. (MudBlazor#5990) * MudDataGrid: Fix CollapseAll not clearing internal variable (MudBlazor#5995) * MudTable: Fixed checkbox state for MultiSelect and (Multi)Grouping (MudBlazor#5985) * Build: Prioritise breaking change label match * MudTable: Toggle multigrouping checkbox ocassionaly flickers (MudBlazor#6003) * Dialog: Fix Unselectable Content Text (MudBlazor#5355) * Build(deps): Bump Microsoft.NET.Test.Sdk from 17.4.0 to 17.4.1 in /src (MudBlazor#6011) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.0 to 17.4.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.4.0...v17.4.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump bunit from 1.12.6 to 1.13.5 in /src (MudBlazor#6015) Bumps [bunit](https://github.com/bUnit-dev/bUnit) from 1.12.6 to 1.13.5. - [Release notes](https://github.com/bUnit-dev/bUnit/releases) - [Changelog](https://github.com/bUnit-dev/bUnit/blob/main/CHANGELOG.md) - [Commits](bUnit-dev/bUnit@v1.12.6...v1.13.5) --- updated-dependencies: - dependency-name: bunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump ReportGenerator from 5.1.12 to 5.1.13 in /src (MudBlazor#6014) Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.1.12 to 5.1.13. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v5.1.12...v5.1.13) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Rename Cancelled to Canceled and forward for non-breaking (MudBlazor#4856) * MudTable: Implement "All" option for MudTablePager. (MudBlazor#5994) * Icons: Remove any <Title> tags on generation (MudBlazor#6023) * Icons: Update material icons (MudBlazor#6034) * MudTabs: Add MinimumTabWidth property (MudBlazor#6044) * MudTabs: Added CustomMinimumTabWidth property * Changed property to "MinimumTabWidth" and added default 160px, removed min-width class style and added permanent inline style. * Removed all references to "Custom" * Prevent BoundingClientRect trimming and throwing JsInteropException (MudBlazor#6053) * MudFileUpload: Remove erroneous semi-colons (MudBlazor#6058) * MudTabPanel: Fix possible System.NullReferenceException on Dispose (MudBlazor#6064) * MudTable: Fix table KeyNotFoundException. (MudBlazor#6065) * MudTabs: Fix TabPanel collections are not in sync (MudBlazor#6070) * Build(deps): Bump Moq from 4.18.3 to 4.18.4 in /src (MudBlazor#6080) Bumps [Moq](https://github.com/moq/moq4) from 4.18.3 to 4.18.4. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](devlooped/moq@v4.18.3...v4.18.4) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * MudAutocomplete: Fix TextChanged event not sending the text (MudBlazor#6120) * Docs: Remove redundant nullable usage of NavigationSection (MudBlazor#6098) * MudTable: Fix 2nd level checkbox default indeterminate state (MudBlazor#6075) * Docs: added note about Elevation and Outlined properties (MudBlazor#6071) * Docs: Show how to use custom SVG icons * Error box: Change background when circuit (connection) is lost. (MudBlazor#6115, MudBlazor#6116) * MudDivider: Fix fullwidth behavior in flex containers (MudBlazor#5458, MudBlazor#5472) * MudTooltip: Fix Style not forwarded to popover (MudBlazor#6045, MudBlazor#6051) * MudDialog: Added Draggable as a DialogOption. (MudBlazor#6083) * Revert "MudDialog: Added Draggable as a DialogOption. (MudBlazor#6083)" due to reported dragging issues. This reverts commit 52134a5. * Build(deps): Bump bunit from 1.13.5 to 1.14.4 in /src (MudBlazor#6156) Bumps [bunit](https://github.com/bUnit-dev/bUnit) from 1.13.5 to 1.14.4. - [Release notes](https://github.com/bUnit-dev/bUnit/releases) - [Changelog](https://github.com/bUnit-dev/bUnit/blob/main/CHANGELOG.md) - [Commits](bUnit-dev/bUnit@v1.13.5...v1.14.4) --- updated-dependencies: - dependency-name: bunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump Microsoft.AspNetCore.Components.WebAssembly in /src (MudBlazor#6159) Bumps [Microsoft.AspNetCore.Components.WebAssembly](https://github.com/dotnet/aspnetcore) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump Microsoft.AspNetCore.Components.WebAssembly.DevServer (MudBlazor#6158) Bumps [Microsoft.AspNetCore.Components.WebAssembly.DevServer](https://github.com/dotnet/aspnetcore) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly.DevServer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump Microsoft.AspNetCore.Components.WebAssembly.Server (MudBlazor#6157) Bumps [Microsoft.AspNetCore.Components.WebAssembly.Server](https://github.com/dotnet/aspnetcore) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly.Server dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * MudTable: Add null check on server data items in FilteredItems (MudBlazor#6186) * MudTable: Enable FluentValidation for TableRowValidator. (MudBlazor#6193) * MudTabs: Fix incorrect ActivePanelIndex (MudBlazor#6100) * Build: Exclude reverted PRs from release notes * MudDateRangePicker: Fix DateRangePicker validation in MudForm (MudBlazor#6194) (MudBlazor#6195) Fixes an issue where the `MudDateRangePicker` component would keep a `MudForm` invalid unless its value was changed via the text input. The `MudDateRangePicker` component is now considered `Touched` if its value is changed via the picker itself. Fixes: MudBlazor#6194 * MudInput: Add Accessibility Titles to Nested Icons (MudBlazor#5531) * Build(deps): Bump ReportGenerator from 5.1.13 to 5.1.15 in /src (MudBlazor#6208) Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.1.13 to 5.1.15. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v5.1.13...v5.1.15) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump FluentAssertions from 6.8.0 to 6.9.0 in /src (MudBlazor#6206) Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.8.0 to 6.9.0. - [Release notes](https://github.com/fluentassertions/fluentassertions/releases) - [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1) - [Commits](fluentassertions/fluentassertions@6.8.0...6.9.0) --- updated-dependencies: - dependency-name: FluentAssertions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * MudOverlay: Fix Absolute property comment (MudBlazor#6225) * MudAutocomplete: Add option to search while an option is selected (MudBlazor#6231) Add Parameter "Strict" which when false shows search results even if something is already selected. * MudTabPanel: Add ShowCloseIcon property (MudBlazor#6197) * MudThemeProvider: Add sudo css selector for generated theme (5781) (MudBlazor#5798) Co-authored-by: Theunis van der Stoep <[email protected]> * Create ROADMAP.md * Update ROADMAP.md * Update ROADMAP.md * Update ROADMAP.md * InputBase: Add ForceUpdate (fixes MudBlazor#5132) (MudBlazor#6266) * MudButton: Add IconSize property (MudBlazor#6040) * Github actions: Add automatic issue/PR labeling (MudBlazor#6257) * Build(deps): Bump ReportGenerator from 5.1.15 to 5.1.16 in /src (MudBlazor#6285) Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.1.15 to 5.1.16. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v5.1.15...v5.1.16) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump bunit from 1.14.4 to 1.15.5 in /src (MudBlazor#6286) Bumps [bunit](https://github.com/bUnit-dev/bUnit) from 1.14.4 to 1.15.5. - [Release notes](https://github.com/bUnit-dev/bUnit/releases) - [Changelog](https://github.com/bUnit-dev/bUnit/blob/main/CHANGELOG.md) - [Commits](bUnit-dev/bUnit@v1.14.4...v1.15.5) --- updated-dependencies: - dependency-name: bunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * MudSwitch: Add Size Parameter (MudBlazor#5673) Co-authored-by: Yan Gauthier <[email protected]> * Tabs: Fix disabling prevButton after upsizing (MudBlazor#6235) (MudBlazor#6236) * MudSwitch: Show Validation ErrorText (MudBlazor#6247) (MudBlazor#6268) Fixes: MudBlazor#6247 * Docs: MudSwitch: Add a separate section for the Size param (MudBlazor#6307) Co-authored-by: Yan Gauthier <[email protected]> * Fix NullReferenceException in ResizeOptions equality logic MudBlazor#6128 (MudBlazor#6308) * Minor fix in Calculator example * Build(deps): Bump FluentValidation from 11.4.0 to 11.5.0 in /src (MudBlazor#6315) * Build(deps): Bump bunit from 1.15.5 to 1.16.2 in /src (MudBlazor#6316) * Build(deps): Bump ReportGenerator from 5.1.16 to 5.1.17 in /src (MudBlazor#6318) * ResizeObserver: Fix typo in directory name (MudBlazor#6303) * Build(deps): Bump FluentAssertions from 6.9.0 to 6.10.0 in /src (MudBlazor#6317) * Tabs: Fix scroll buttons not working on low width (MudBlazor#5212, MudBlazor#6304) * MudDialog: CSS fix for scroll when size is greater than view height (MudBlazor#3368, MudBlazor#4132) * MudTabs: Optionally cancel tab panel activations (MudBlazor#4738) * Build(deps): Bump Microsoft.AspNetCore.Components.WebAssembly.DevServer (MudBlazor#6352) * Build(deps): Bump Microsoft.AspNetCore.Components.WebAssembly.Server (MudBlazor#6354) * MudPicker: Fix flickering in delayed BSS (MudBlazor#5450, MudBlazor#3425, MudBlazor#6344) * Build(deps): Bump Microsoft.AspNetCore.Components.WebAssembly in /src (MudBlazor#6355) * MudCheckbox: Use flex-row-reverse instead of mud-rtl (Fixes MudBlazor#5634) (MudBlazor#6377) * MudTable: Fix V3022 warning (MudBlazor#6374) * Build(deps): Bump NUnit3TestAdapter from 4.3.1 to 4.4.0 in /src (MudBlazor#6397) * Build(deps): Bump bunit from 1.16.2 to 1.18.4 in /src (MudBlazor#6400) * Build(deps): Bump FluentValidation from 11.5.0 to 11.5.1 in /src (MudBlazor#6401) * Build(deps): Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0 in /src (MudBlazor#6398) * Build(deps): Bump ReportGenerator from 5.1.17 to 5.1.18 in /src (MudBlazor#6399) * Move Mr-Technician to core team. (MudBlazor#6402) * Autocomplete: Correct summary for Strict (MudBlazor#6396) * Avatar: Refactor Image support (MudBlazor#6382) * Refactor Avatar. * Remove Category attributes from obsolete parameters. * Update src/MudBlazor/Components/Avatar/MudAvatar.razor Co-authored-by: Jonas B. <[email protected]> * Update src/MudBlazor/Components/Avatar/MudAvatar.razor.cs Co-authored-by: Jonas B. <[email protected]> * Update src/MudBlazor/Components/Avatar/MudAvatar.razor.cs Co-authored-by: Jonas B. <[email protected]> --------- Co-authored-by: Jonas B. <[email protected]> * Dialog: Fix issues with nested inline Dialogs (MudBlazor#6390) * Add ForceInline option to Dialog. * Clarify unit test. * Add force inline dialog docs. * Remove ForceInline parameter. * Rewrite docs. * Improve nested inline dialog docs. * Remove ForceInline from datagrid. * MudCarousel: Fix wrong transition direction when using SelectedIndex (MudBlazor#6392, MudBlazor#6394) * MudMenu: Fix Touch Bubbling Which Causes Other Unwanted Click Event Firing on Mobile Devices (MudBlazor#6358) * Update README.md (MudBlazor#6339) * Docs: MudDialog clarifications and formatting fixes * MudDataGrid: Configuration using expressions (MudBlazor#6049) MudDataGrid: Configuration using expressions (MudBlazor#6049) Co-authored-by: Terry Phillips <[email protected]> * Docs: Remove experimental warning from MudDataGrid. * MudDropZone: Add support for Chromium based browsers on Mobile (MudBlazor#4818) MudDropZone: Add support for Chromium based browsers on Mobile (MudBlazor#4818) * SourceCodeGenerator: Add support for enum source code generation (MudBlazor#6306) SourceCodeGenerator: Add support for enum source code generation (MudBlazor#6306) * Fix .csproj formatting (MudBlazor#6422) * Fix analyzer NullReferenceException in old ToDescriptionString, add test scanrio for it. (MudBlazor#6423) * Datagrid: Fix Dialog (MudBlazor#6415) * MudDropZone: Fix code formatting (MudBlazor#6425) * MudDataGrid : Fixes Select All when using ServerData (MudBlazor#5999) * Fixes Select All on MudDataGrid when using ServerData Fixes MudBlazor#5555 * ThemeProvider: Allow watching dark/light system setting (MudBlazor#6320) Watch dark light theme settings for system. Co-authored-by: Jonas B. <[email protected]> * Make sure the loading indicator is shown when loading from server (by invoking StateHasChanged asynchronously) (MudBlazor#4665) Refactor code to make use of the HasServerData property available Co-authored-by: Simon Ensslen <[email protected]> * README.md grammar fix * Update README.md * ThemeProvider: Trimming and minor formatting fix (MudBlazor#6444) * Build(deps): Bump NUnit3TestAdapter from 4.4.0 to 4.4.2 in /src (MudBlazor#6434) Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 4.4.0 to 4.4.2. - [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases) - [Commits](nunit/nunit3-vs-adapter@V4.4.0...V4.4.2) --- updated-dependencies: - dependency-name: NUnit3TestAdapter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): Bump Microsoft.CodeAnalysis.CSharp in /src (MudBlazor#6435) Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Kuro to the contribution team and fix obsolete warnings. (MudBlazor#6446) * Fix obsolete workaround for images in MudAvatar. (MudBlazor#6448) * RadioGroup: Add ReadOnly and Disabled options. (MudBlazor#6418) * Add ReadOnly and Disabled options to RadioGroup. * Add unit tests. * Docs: correct class name in Snackbar>Configuration (MudBlazor#6447) Co-authored-by: Jason Brandt <[email protected]> * MudDatePicker: Add disabled functionality for months only picker (MudBlazor#6438) * added disabled functionality for months only picker --------- Co-authored-by: Jakob Sorgeloos <[email protected]> Co-authored-by: Jakob <[email protected]> * MudDataGrid: Fix missing content/error in Cell edit mode for HierarchyColumn (MudBlazor#6024) * MudDatePicker: Disable months if day is fixed (MudBlazor#6336) (MudBlazor#6338) * MudDatePicker: Add disabling months if day is fixed (MudBlazor#6336) * Docs: Fix release page and roadmap page (MudBlazor#6455) * Docs: Fixed markdown on release page * Remade into list and less custom css * Added page title to release page * Added roadmap from the GitHub markdown file * Added roadmap link to connect-src * Added support for older releases and its markdown * Build(deps): Bump ReportGenerator from 5.1.18 to 5.1.19 in /src (MudBlazor#6461) Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.1.18 to 5.1.19. - [Release notes](https://github.com/danielpalme/ReportGenerator/releases) - [Commits](danielpalme/ReportGenerator@v5.1.18...v5.1.19) --- updated-dependencies: - dependency-name: ReportGenerator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * MudBaseInput: Obsolete OnKeyPress, to be removed in v7 (MudBlazor#6464) * Autocomplete: Fix Autocomplete opening on Reset (MudBlazor#6387) * Fix issue where autocompletes would open upon reset using server side blazor. * Revert "SetText should be string.Empty, not null." This reverts commit b36b2ec. * MudAutocomplete: Fix KeyDown Event (MudBlazor#6462) * added tests for keydown event Co-authored-by: Jakob Sorgeloos <[email protected]> * MudDataGrid: change status from experimental to stable in docs * MudDialog: Change OnBackdropClick Action to EventCallback (MudBlazor#6151) * Changed MudDialog's OnBackdropClick delegate to support async methods. Closes MudBlazor#6146 --------- Co-authored-by: Meinrad Recheis <[email protected]> * MudTable: Add filtered items cache for each render. (MudBlazor#6470) * MudTable: Add filtered items cache for each render. --------- Co-authored-by: Štěpán Adámek <[email protected]> * MudDataGrid: Improve nullability, encapsulation and some nits (MudBlazor#6421) * Improve nullability, encapsulation and some nits in DataGrid * MudDataGrid: Sorting and filtering performance improvements. (MudBlazor#6495) * MudDataGrid: Improve sorting and filtering performance using FilteredItems cache. * MudDataTable: Ensure PropertyFunc is compiled only once. --------- Co-authored-by: Štěpán Adámek <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: TDroogers <[email protected]> Co-authored-by: Riley Nielsen <[email protected]> Co-authored-by: Meinrad Recheis <[email protected]> Co-authored-by: Mike Surcouf <[email protected]> Co-authored-by: Gary Chan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jonny Larsson <[email protected]> Co-authored-by: dennml <[email protected]> Co-authored-by: Daniele Corsini <[email protected]> Co-authored-by: nick <[email protected]> Co-authored-by: Jeffrey Jangli <[email protected]> Co-authored-by: Adam Renaud <[email protected]> Co-authored-by: Pawel <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: DoobieAsDave <[email protected]> Co-authored-by: David Griesser <[email protected]> Co-authored-by: Artyom M <[email protected]> Co-authored-by: Mehmet Can Karagöz <[email protected]> Co-authored-by: Abduwaris Ghujamniyaz <[email protected]> Co-authored-by: Dennis Mlinaric <[email protected]> Co-authored-by: Jonas B <[email protected]> Co-authored-by: Gopichandar Selvaraj <[email protected]> Co-authored-by: Michel de Kok <[email protected]> Co-authored-by: Andrew Palmer <[email protected]> Co-authored-by: Florian Dengg <[email protected]> Co-authored-by: Florian <[email protected]> Co-authored-by: Riley Nielsen <[email protected]> Co-authored-by: Jason Rebelo <[email protected]> Co-authored-by: popandepo <[email protected]> Co-authored-by: Stuart Aitken <[email protected]> Co-authored-by: SinisterMaya <[email protected]> Co-authored-by: Massimo Giambona <[email protected]> Co-authored-by: Chris <[email protected]> Co-authored-by: David V <[email protected]> Co-authored-by: Lennart Kleymann <[email protected]> Co-authored-by: Makhmutov Neil <[email protected]> Co-authored-by: pars-dev <[email protected]> Co-authored-by: Suenodk <[email protected]> Co-authored-by: snakex64 <[email protected]> Co-authored-by: Bevan Weiss <[email protected]> Co-authored-by: Qian <[email protected]> Co-authored-by: Hayden Ravenscroft <[email protected]> Co-authored-by: Idan <[email protected]> Co-authored-by: WalterWillis <[email protected]> Co-authored-by: Martin Lantzsch <[email protected]> Co-authored-by: stoepa <[email protected]> Co-authored-by: Theunis van der Stoep <[email protected]> Co-authored-by: Yan Gauthier <[email protected]> Co-authored-by: Łukasz Prajer <[email protected]> Co-authored-by: Habetdin <[email protected]> Co-authored-by: Keith <[email protected]> Co-authored-by: Lukas Klinger <[email protected]> Co-authored-by: Henrique Clausing <[email protected]> Co-authored-by: Marius <[email protected]> Co-authored-by: Terry Phillips <[email protected]> Co-authored-by: Terry Phillips <[email protected]> Co-authored-by: Henry <[email protected]> Co-authored-by: Justin Lampe <[email protected]> Co-authored-by: alfadelta88 <[email protected]> Co-authored-by: Simon Ensslen <[email protected]> Co-authored-by: Simon Ensslen <[email protected]> Co-authored-by: dev-jlb <[email protected]> Co-authored-by: Jason Brandt <[email protected]> Co-authored-by: Jakob Sorgeloos <[email protected]> Co-authored-by: Jakob Sorgeloos <[email protected]> Co-authored-by: Jakob <[email protected]> Co-authored-by: adameste <[email protected]> Co-authored-by: Štěpán Adámek <[email protected]>

…6151) * Changed MudDialog's OnBackdropClick delegate to support async methods. Closes MudBlazor#6146 --------- Co-authored-by: Meinrad Recheis <[email protected]>

BieleckiLtd and others added 2 commits January 15, 2023 22:33

Swapped MudDialog's OnBackdropClick delegate to support async methods. …

cfbe499

…Closes #6146

Merge branch 'dev' into feature/dialog-backdropclick-async

3f28f37

mikes-gh changed the title ~~Swapped MudDialog's OnBackdropClick delegate to support async methods~~ MudDialog: Change OnBackdropClick Action to EvenCallback Jan 18, 2023

mikes-gh added the enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library label Jan 18, 2023

mikes-gh changed the title ~~MudDialog: Change OnBackdropClick Action to EvenCallback~~ MudDialog: Change OnBackdropClick Action to EventCallback Jan 18, 2023

Merge branch 'dev' into feature/dialog-backdropclick-async

4e26fa9

Update MudDialogInstance.razor

561f795

Method renamed to be HandleBackgroundClickAsync

henon reviewed Mar 16, 2023

View reviewed changes

src/MudBlazor/Components/Dialog/MudDialogInstance.razor.cs Outdated Show resolved Hide resolved

Update MudDialogInstance.razor.cs

c4950a9

Added null check in case _dialog is null.

henon approved these changes Mar 16, 2023

View reviewed changes

henon merged commit 95a317b into MudBlazor:dev Mar 16, 2023

BieleckiLtd deleted the feature/dialog-backdropclick-async branch March 16, 2023 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MudDialog: Change OnBackdropClick Action to EventCallback#6151

MudDialog: Change OnBackdropClick Action to EventCallback#6151
henon merged 5 commits intoMudBlazor:devfrom
BieleckiLtd:feature/dialog-backdropclick-async

BieleckiLtd commented Jan 15, 2023

Uh oh!

codecov bot commented Jan 16, 2023 •

edited

Loading

Uh oh!

henon commented Mar 14, 2023

Uh oh!

BieleckiLtd commented Mar 15, 2023

Uh oh!

henon commented Mar 15, 2023

Uh oh!

henon commented Mar 15, 2023

Uh oh!

BieleckiLtd commented Mar 16, 2023

Uh oh!

Uh oh!

henon commented Mar 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

BieleckiLtd commented Jan 15, 2023

Description

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

codecov bot commented Jan 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

henon commented Mar 14, 2023

Uh oh!

BieleckiLtd commented Mar 15, 2023

Uh oh!

henon commented Mar 15, 2023

Uh oh!

henon commented Mar 15, 2023

Uh oh!

BieleckiLtd commented Mar 16, 2023

Uh oh!

Uh oh!

henon commented Mar 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 16, 2023 •

edited

Loading