Skip to content

MudTable: Provide contextual item data when using EditButtonContent#6129

Merged
Mr-Technician merged 3 commits intoMudBlazor:devfrom
stho01:feature/mudtable-add-item-to-edit-context
Mar 19, 2024
Merged

MudTable: Provide contextual item data when using EditButtonContent#6129
Mr-Technician merged 3 commits intoMudBlazor:devfrom
stho01:feature/mudtable-add-item-to-edit-context

Conversation

@stho01
Copy link
Contributor

@stho01 stho01 commented Jan 11, 2023

Description

This pull requests adds the contextual item data to EditButtonContext

resolves #5887

How Has This Been Tested?

Visually, unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@stho01 stho01 changed the title Feature/mudtable add item to edit context MudTable: Provide contextual item data when using EditButtonContent Jan 11, 2023
@mikes-gh mikes-gh added the enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library label Jan 11, 2023
@Mr-Technician
Copy link
Member

Mr-Technician commented Jan 13, 2023

Looks good to me. I attempted to do this with T but as MudTr is not generic it was not straightforward to do so. I think this is the best solution for now, at least.

@Mr-Technician Mr-Technician mentioned this pull request Jan 13, 2023
Closed
2 tasks
@nlpsl202
Copy link

nlpsl202 commented Aug 31, 2023

Same problem, is item already added to EditButtonContent?

@stho01 stho01 requested a review from Mr-Technician September 4, 2023 09:50
@tainguyenvl
Copy link

tainguyenvl commented Sep 8, 2023

Do you know if we can use it in version 6.9.0?

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (91ebd58) 90.61% compared to head (1d9c759) 90.63%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #6129      +/-   ##
==========================================
+ Coverage   90.61%   90.63%   +0.01%     
==========================================
  Files         427      427              
  Lines       15198    15198              
==========================================
+ Hits        13772    13774       +2     
+ Misses       1426     1424       -2
Files Changed Coverage Δ
...rc/MudBlazor/Components/Table/EditButtonContext.cs 100.00% <ø> (ø)
src/MudBlazor/Components/Table/MudTr.razor 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stho01
Copy link
Contributor Author

stho01 commented Sep 11, 2023

Updated to latest changes in dev now. Looks like all tests goes green.

@Alessandro-Irinox
Copy link

Alessandro-Irinox commented Mar 13, 2024

any news for this?

Mr-Technician
Mr-Technician approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Mr-Technician Mr-Technician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stho01
Copy link
Contributor Author

stho01 commented Mar 19, 2024

Anything more that needs to be done to get this merged in?

@Mr-Technician Mr-Technician merged commit 9716edc into MudBlazor:dev Mar 19, 2024
@Alessandro-Irinox
Copy link

Alessandro-Irinox commented Mar 20, 2024

When will this change be put into production?

@Mr-Technician
Copy link
Member

Mr-Technician commented Mar 20, 2024

@Alessandro-Irinox It is available in the latest production build (6.18.0): https://github.com/MudBlazor/MudBlazor/releases/tag/v6.18.0

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@stho01 @biegehydra
MudTable: Provide contextual item data when using EditButtonContent (M…
8177ba4 
…udBlazor#6129)

* MudTable: Add item to edit context

* MudTable: Add unit test that test that row item data is passed to
EditButtonContext
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mr-Technician Mr-Technician Mr-Technician approved these changes

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MudTable: Provide contextual item data when using EditButtonContent

6 participants

@stho01 @Mr-Technician @nlpsl202 @tainguyenvl @Alessandro-Irinox @mikes-gh