MudTabPanel: Add ShowCloseIcon property by Yomodo · Pull Request #6062 · MudBlazor/MudBlazor

Yomodo · 2022-12-30T01:07:04Z

Description

This PR adds the ShowCloseIcon=true property to MudTabPanel to show/hide the close icon
when using MudDynamicTabs.

Use cases:
-Sometimes we just need to prevent closing a tab, e.g. stuff still in progress;
-Sometimes a minimal tab of 1 is mandatory;

How Has This Been Tested?

unit | visually

Types of changes

-Updated docs and some doc corrections.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

The PR is submitted to the correct branch (dev).
My code follows the code style of this project.
I've added relevant tests.

codecov · 2022-12-30T01:10:59Z

Codecov Report

Base: 91.52% // Head: 91.53% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bb99a73) compared to base (a6116c6).
Patch coverage: 96.66% of modified lines in pull request are covered.

❗ Current head bb99a73 differs from pull request most recent head 2ead079. Consider uploading reports for the commit 2ead079 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #6062   +/-   ##
=======================================
  Coverage   91.52%   91.53%           
=======================================
  Files         383      383           
  Lines       15019    15023    +4     
=======================================
+ Hits        13746    13751    +5     
+ Misses       1273     1272    -1

Impacted Files	Coverage Δ
src/MudBlazor/Components/Tabs/MudTabPanel.razor	`100.00% <ø> (ø)`
src/MudBlazor/Components/Tabs/MudDynamicTabs.razor	`99.31% <96.66%> (+0.01%)`	⬆️
...r/Components/Autocomplete/MudAutocomplete.razor.cs	`92.85% <0.00%> (+0.42%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This reverts commit 904559f.

src/MudBlazor/Components/Tabs/MudTabPanel.razor

mikes-gh · 2022-12-30T17:17:04Z

Thanks @Yomodo
I know its frustrating but could you fix the indenting.
Looks like the previous developer used Tabs for indents instead of spaces.

Yomodo · 2022-12-30T17:48:28Z

I know its frustrating but could you fix the indenting.
Looks like the previous developer used Tabs for indents instead of spaces.

Indeed, but surely it is acceptable since indents are now spaces and the formatting overall still looks ok?
I did try to correct indenting but only made it worse and reverted that,
I really don't want to spent more time on that. I tried.

Yomodo · 2022-12-31T11:26:25Z

I'll try again.

…or#6075)

)

…lazor#6115, MudBlazor#6116)

…MudBlazor#5472)

…azor#6051)

…" due to reported dragging issues. This reverts commit 52134a5.

Bumps [bunit](https://github.com/bUnit-dev/bUnit) from 1.13.5 to 1.14.4. - [Release notes](https://github.com/bUnit-dev/bUnit/releases) - [Changelog](https://github.com/bUnit-dev/bUnit/blob/main/CHANGELOG.md) - [Commits](bUnit-dev/bUnit@v1.13.5...v1.14.4) --- updated-dependencies: - dependency-name: bunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…MudBlazor#6159) Bumps [Microsoft.AspNetCore.Components.WebAssembly](https://github.com/dotnet/aspnetcore) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…er (MudBlazor#6158) Bumps [Microsoft.AspNetCore.Components.WebAssembly.DevServer](https://github.com/dotnet/aspnetcore) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly.DevServer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…udBlazor#6157) Bumps [Microsoft.AspNetCore.Components.WebAssembly.Server](https://github.com/dotnet/aspnetcore) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly.Server dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…azor#6186)

…6193)

mikes-gh · 2023-01-22T11:39:52Z

Hi @Yomodo could you fix the conflicts please Thanks

Yomodo · 2023-01-22T13:23:57Z

Will do!

This reverts commit 904559f.

Yomodo · 2023-01-22T15:45:34Z

Now sure how, but it got messy :(
I will close this PR and open a new one.

Added ShowCloseIcon property, updated docs

cbf1bf2

Yomodo added 3 commits December 30, 2022 12:41

Fixed formatting

865af62

Formatting

904559f

Revert "Formatting"

84f7e3c

This reverts commit 904559f.

mikes-gh added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library API change Modifies the public API surface labels Dec 30, 2022

iwis reviewed Dec 30, 2022

View reviewed changes

src/MudBlazor/Components/Tabs/MudTabPanel.razor Outdated Show resolved Hide resolved

Corrected property CategoryTypes

df5794d

Yomodo and others added 16 commits December 31, 2022 13:38

indent fixing, another attempt

bb99a73

MudTable: Fix 2nd level checkbox default indeterminate state (MudBlaz…

a76b2ef

…or#6075)

Docs: added note about Elevation and Outlined properties (MudBlazor#6071

13f3f33

)

Docs: Show how to use custom SVG icons

9a56dda

Error box: Change background when circuit (connection) is lost. (MudB…

2a7d172

…lazor#6115, MudBlazor#6116)

MudDivider: Fix fullwidth behavior in flex containers (MudBlazor#5458, …

4f8841f

…MudBlazor#5472)

MudTooltip: Fix Style not forwarded to popover (MudBlazor#6045, MudBl…

d4a8b18

…azor#6051)

MudDialog: Added Draggable as a DialogOption. (MudBlazor#6083)

52134a5

Revert "MudDialog: Added Draggable as a DialogOption. (MudBlazor#6083)…

3ab1b00

…" due to reported dragging issues. This reverts commit 52134a5.

MudTable: Add null check on server data items in FilteredItems (MudBl…

1d88dc2

…azor#6186)

MudTable: Enable FluentValidation for TableRowValidator. (MudBlazor#…

af789a4

…6193)

MudTabs: Fix incorrect ActivePanelIndex (MudBlazor#6100)

630b027

Yomodo added 6 commits January 22, 2023 16:41

Added ShowCloseIcon property, updated docs

6c3e829

Formatting

0739d6f

Revert "Formatting"

c08110d

This reverts commit 904559f.

Corrected property CategoryTypes

1340dff

indent fixing, another attempt

63d393d

rebase

2ead079

Yomodo closed this Jan 22, 2023

Yomodo deleted the MudTabPanelShowCloseIcon branch January 22, 2023 18:50

Yomodo mentioned this pull request Jan 22, 2023

MudTabPanel: Add ShowCloseIcon property #6197

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MudTabPanel: Add ShowCloseIcon property#6062

MudTabPanel: Add ShowCloseIcon property#6062
Yomodo wants to merge 27 commits intoMudBlazor:devfrom
Yomodo:MudTabPanelShowCloseIcon

Yomodo commented Dec 30, 2022

Uh oh!

codecov bot commented Dec 30, 2022 •

edited

Loading

Uh oh!

Uh oh!

mikes-gh commented Dec 30, 2022

Uh oh!

Yomodo commented Dec 30, 2022

Uh oh!

Yomodo commented Dec 31, 2022

Uh oh!

mikes-gh commented Jan 22, 2023

Uh oh!

Yomodo commented Jan 22, 2023

Uh oh!

Yomodo commented Jan 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Yomodo commented Dec 30, 2022

Description

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

codecov bot commented Dec 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mikes-gh commented Dec 30, 2022

Uh oh!

Yomodo commented Dec 30, 2022

Uh oh!

Yomodo commented Dec 31, 2022

Uh oh!

mikes-gh commented Jan 22, 2023

Uh oh!

Yomodo commented Jan 22, 2023

Uh oh!

Yomodo commented Jan 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Dec 30, 2022 •

edited

Loading