MudRating: Added optional parameters for Full and Empty Icon Color#5463
Conversation
Added optional parameters for Full and Empty Icon Color. If not specified, behavior remains the same, otherwise it changes the color of the item based on full/empty.
604f5c8 to
366c9ef
Compare
|
Hi @nejckikelj, and thanks for your PR. Before looking closely into your code changes, it would be great if you could add some unit tests for these new parameters. A new example in the docs would be appreciated as well. |
|
Hi @just-the-benno, thanks for the comment. Unit tests and docs example added. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5463 +/- ##
==========================================
+ Coverage 89.82% 90.49% +0.66%
==========================================
Files 412 396 -16
Lines 11878 12140 +262
Branches 2364 2369 +5
==========================================
+ Hits 10670 10986 +316
+ Misses 681 621 -60
- Partials 527 533 +6 ☔ View full report in Codecov by Sentry. |
Added another test to cover all scenarios
9e1340d to
c29ac0f
Compare
|
Just checking on this PR ? :) |
|
Hello, Thank you for the PR. My apologies for the delay in response. I need to consult with a team member to decide whether we should close this PR or revive it and merge. @henon, do you think I should revive this PR by resolving conflicts? This PR makes sense. Ideally, having a |
|
Yes, this makes sense. |
|
Sorry, misclicked ;) |
|
@henon this is ready for review. |
Added optional parameters for Full and Empty Icon Color. If not specified, behavior remains the same, otherwise it changes the color of the item based on full/empty.
Description
Added option to select Full and Empty Icon Color, since it couldn't be done simply.
How Has This Been Tested?
visually, using automated tests.
Types of changes
Checklist:
dev).