Skip to content

fix crash when trying to set a property without a setter#5396

Closed
johmarjac wants to merge 1 commit intoMudBlazor:devfrom
johmarjac:fix/DataGridEditSetterPropertiesOnly
Closed

fix crash when trying to set a property without a setter#5396
johmarjac wants to merge 1 commit intoMudBlazor:devfrom
johmarjac:fix/DataGridEditSetterPropertiesOnly

Conversation

@johmarjac
Copy link

@johmarjac johmarjac commented Sep 30, 2022

Description

I added a condition to fix a crash with the manual Edit mode of the datagrid when the Model contains properties that has only a getter but not a setter.

How Has This Been Tested?

By testing it myself when I first faced this issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 91.41% // Head: 91.40% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1f58861) compared to base (5137dd0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #5396      +/-   ##
==========================================
- Coverage   91.41%   91.40%   -0.01%     
==========================================
  Files         372      372              
  Lines       14811    14812       +1     
==========================================
  Hits        13539    13539              
- Misses       1272     1273       +1     
Impacted Files Coverage Δ
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 80.62% <0.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mr-Technician
Copy link
Member

Closing in lieu of #5428 which includes a test. Thank you though @johmarjac!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants