Skip to content

MudDataGrid: Added the case sensitivity when filtering string columns#5320

Merged
just-the-benno merged 1 commit intoMudBlazor:devfrom
nicoarm93:feature/datagrid-filterCaseSensitivity
Sep 27, 2022
Merged

MudDataGrid: Added the case sensitivity when filtering string columns#5320
just-the-benno merged 1 commit intoMudBlazor:devfrom
nicoarm93:feature/datagrid-filterCaseSensitivity

Conversation

@nicoarm93
Copy link
Contributor

Description

This pull request add the possibility to define the case sensitivity when filtering string values. I have added the parameter FilterCaseSensitivity to the MudDataGrid to do so. The default behavior is not changed.

How Has This Been Tested?

It is been tested updating existing unit tests and visually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

image

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 91.37% // Head: 91.38% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7333927) compared to base (9128a54).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #5320   +/-   ##
=======================================
  Coverage   91.37%   91.38%           
=======================================
  Files         372      372           
  Lines       14778    14805   +27     
=======================================
+ Hits        13503    13529   +26     
- Misses       1275     1276    +1     
Impacted Files Coverage Δ
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 80.09% <ø> (-0.25%) ⬇️
.../MudBlazor/Components/DataGrid/FilterDefinition.cs 94.92% <100.00%> (+0.26%) ⬆️
src/MudBlazor/Components/Chart/MudChart.razor.cs 86.36% <0.00%> (ø)
...c/MudBlazor/Components/Tooltip/MudTooltip.razor.cs 97.43% <0.00%> (ø)
...azor/Components/Drawer/MudDrawerContainer.razor.cs 97.72% <0.00%> (ø)
...r/Components/Autocomplete/MudAutocomplete.razor.cs 92.43% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@just-the-benno
Copy link
Contributor

@tjscience can you have a look at this PR?

@tjscience
Copy link
Contributor

@nicoarm93, this is a good idea and thank you for implementing it. I originally thought that it might be useful to have this parameter on Column as well for more granular control, but I think that it is overkill. @just-the-benno, this one is good to go.

@just-the-benno just-the-benno merged commit 0cfb354 into MudBlazor:dev Sep 27, 2022
@just-the-benno
Copy link
Contributor

Thank you, both of you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants