Skip to content

MudChip and MudChipset: Support Generic#4342

Merged
ScarletKuro merged 19 commits intoMudBlazor:devfrom
mckaragoz:ChipGeneric
Mar 31, 2024
Merged

MudChip and MudChipset: Support Generic#4342
ScarletKuro merged 19 commits intoMudBlazor:devfrom
mckaragoz:ChipGeneric

Conversation

@mckaragoz
Copy link
Member

@mckaragoz mckaragoz commented Apr 3, 2022 •
edited by henon
Loading

Description

Chipsets and Chips now support generic types.

This is a breaking change because now users have to give value to chips to work selection and multi selection properly.

Additional info by Henon:
The internal logic was changed to use our new state framework and thus the following bugs are fixed on the go:
resolves #1462
resolves #8267
resolves #7964
resolves #5039
resolves #5420

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@mckaragoz mckaragoz added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library breaking change This change will require consumer code updates API change Modifies the public API surface labels Apr 3, 2022
@codecov
Copy link

codecov bot commented Apr 3, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.24324% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.37%. Comparing base (704d3e7) to head (0889105).
Report is 2 commits behind head on dev.

Files Patch % Lines
src/MudBlazor/Components/Chip/MudChip.razor.cs 92.85% 0 Missing and 3 partials ⚠️
...c/MudBlazor/Components/ChipSet/MudChipSet.razor.cs 92.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #4342      +/-   ##
==========================================
+ Coverage   89.29%   89.37%   +0.08%     
==========================================
  Files         411      411              
  Lines       11900    11860      -40     
  Branches     2356     2353       -3     
==========================================
- Hits        10626    10600      -26     
+ Misses        751      737      -14     
  Partials      523      523

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mckaragoz mckaragoz marked this pull request as ready for review April 3, 2022 21:06
@mckaragoz mckaragoz mentioned this pull request Aug 23, 2022
Draft
@mikes-gh mikes-gh changed the title Chip and Chipset: Support Generic MudChip and MudChipset: Support Generic Sep 13, 2022
@BluePoof BluePoof mentioned this pull request Oct 3, 2022
Closed
2 tasks
@danielchalmers danielchalmers mentioned this pull request Mar 24, 2024
Closed
6 tasks
@henon henon mentioned this pull request Mar 29, 2024
Closed
@henon henon requested a review from ScarletKuro March 29, 2024 20:23
@henon
Copy link
Contributor

henon commented Mar 29, 2024

Ready for review @ScarletKuro, @mckaragoz

@henon
Copy link
Contributor

henon commented Mar 29, 2024

I added Variant and Color to ChipSet so it can be set for all chips at the same time. But now I realize the same should then be done for Size, SelectedColor, Label, CheckedIcon, IconColor, CloseIcon and DisableRipple and I am not sure.

Shall I revert Variant and Color in ChipSet?

This was referenced Mar 29, 2024
Merged
Closed
This was referenced Mar 29, 2024
Open
Closed
Closed
@henon henon removed the request for review from just-the-benno March 30, 2024 00:48
ScarletKuro
ScarletKuro reviewed Mar 30, 2024
View reviewed changes
@ScarletKuro
Copy link
Member

ScarletKuro commented Mar 30, 2024

I hope this is rebased against latest changes?

@ScarletKuro
Copy link
Member

ScarletKuro commented Mar 30, 2024

I added Variant and Color to ChipSet so it can be set for all chips at the same time. But now I realize the same should then be done for Size, SelectedColor, Label, CheckedIcon, IconColor, CloseIcon and DisableRipple and I am not sure.

Shall I revert Variant and Color in ChipSet?

Does all this property make sense in the context of ChipSet?
If yes, we should probably add them, but if you are short on time just leave as is, we could extend later?

@henon
Copy link
Contributor

henon commented Mar 30, 2024

I hope this is rebased against latest changes?

Yes, merged instead of rebased as it is less effort to resolve conflicts

@henon
Copy link
Contributor

henon commented Mar 30, 2024

Thanks for the thorough review. Should all be fixed. I'll add the properties to ChipSet. They are relevant insofar as it allows to set a uniform default value for all chips in the set.

@ScarletKuro
Copy link
Member

ScarletKuro commented Mar 30, 2024

Dotnet format is already in action 😂

@henon
Copy link
Contributor

henon commented Mar 30, 2024

I think this is ready to merge

@ScarletKuro ScarletKuro merged commit e4ec689 into MudBlazor:dev Mar 31, 2024
@ScarletKuro
Copy link
Member

ScarletKuro commented Mar 31, 2024

@mckaragoz @henon thanks!

@ScarletKuro
Copy link
Member

ScarletKuro commented Apr 1, 2024

Explicit link mention that nullable annotation was done for #6535

@henon henon mentioned this pull request Apr 17, 2024
Merged
7 tasks
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@mckaragoz @henon @biegehydra
MudChip and MudChipset: Support Generic (MudBlazor#4342)
b393332 
Co-authored-by: Meinrad Recheis <[email protected]>
@henon henon added the legendary Marks contributions that are highly valuable, innovative, or significantly impactful to the project label Jun 20, 2024
@dependabot dependabot bot mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon henon left review comments

@ScarletKuro ScarletKuro ScarletKuro approved these changes

Assignees

No one assigned

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library legendary Marks contributions that are highly valuable, innovative, or significantly impactful to the project

Projects

None yet

Milestone

No milestone

3 participants

@mckaragoz @henon @ScarletKuro