MudDatePicker: Fix Display of Min and Max Date and MaxValue Crash by mckaragoz · Pull Request #4088 · MudBlazor/MudBlazor

mckaragoz · 2022-03-02T20:15:49Z

Description

Fixes #4087.

Fix min and max date to working properly on OpenTo.Month and OpenTo.Year.

How Has This Been Tested?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

20220302_224304.mp4

Checklist:

The PR is submitted to the correct branch (dev).
My code follows the code style of this project.
I've added relevant tests.

codecov · 2022-03-02T20:19:43Z

Codecov Report

❌ Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.13%. Comparing base (dd2b8c1) to head (044c600).
⚠️ Report is 2370 commits behind head on dev.

Files with missing lines	Patch %	Lines
...r/Components/DatePicker/MudBaseDatePicker.razor.cs	83.33%	8 Missing ⚠️
...c/MudBlazor/Components/DatePicker/MudDatePicker.cs	50.00%	1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (84.74%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #4088      +/-   ##
==========================================
- Coverage   91.22%   91.13%   -0.09%     
==========================================
  Files         359      359              
  Lines       12434    12482      +48     
==========================================
+ Hits        11343    11376      +33     
- Misses       1091     1106      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JonBunator

In my opinion, it's way better UX if the buttons are either disabled or completely hidden (arrows).
It creates a false impression that something should happen when you get click feedback, but nothing happens.

mckaragoz · 2022-03-23T18:45:59Z

So here the last news:

Only years which between min and max show
Year navigate button disappear in month view if they not inside min and max
Mont navigate button disappear in day view if they not inside min and max

@JonBunator i added to show/hide buttons related to min max date, thats a great suggestion.

20220323_213659.mp4

If its done, i will prepare tests and then merge.

src/MudBlazor/Components/DatePicker/MudBaseDatePicker.razor

mckaragoz · 2022-03-24T14:50:59Z

So here is the last news. I think its solid now.

This is the last shape of when we reach MaxDate, next button disappears (same for the month view) and exceed days disabled. We have the reversed version for the MinDate.

In current, DatePicker crashes when we try to go beyond to the max value, its fixed now. (Next button is hidden now, yes, but also fix the code so if there is even a button, it didn't give exception when you click it.) And also we hide buttons for the DateTime.MinValue and DateTime.MaxValue

20220324_172455.mp4

And what about change date programmatically? Now we disabled that now date changing more than max and less then min have no effect. (This example shows that Min-Max picker value didn't changed although they are all connected by the same value)

20220324_173344.mp4

So if its good, there are only tests missing.

mckaragoz · 2022-03-24T14:56:03Z

src/MudBlazor/Styles/components/_pickerdate.scss

    }
 }

-:not(.mud-picker-hidden) {


@Garderoben i deleted this because prev button has not this kind of style and this !important prevents all visibility styling. We already fix the max date problem so i think this is not necessary. Could you look at this?

mckaragoz · 2022-03-24T14:57:29Z

src/MudBlazor/Components/DatePicker/MudBaseDatePicker.razor.cs

            return Culture.Calendar.GetDayOfMonth(date);
        }

+        private void UpdateMinMaxDateExceedStatus()


@henon could you look at this? This method runs onafterrender(firstrender is true) and each time PickerMonth is changed. Is it simple enough?

This is actually not a good way of doing it. Keeping state in private variables is always more error prone than just calculating that state. Instead you can add four private functions that calculate these states.

henon

Use calculated state instead of stored state. Then tests, then this can be merged.

henon · 2022-12-10T21:16:46Z

src/MudBlazor/Components/DatePicker/MudBaseDatePicker.razor.cs

            return Culture.Calendar.GetDayOfMonth(date);
        }

+        private void UpdateMinMaxDateExceedStatus()


This is actually not a good way of doing it. Keeping state in private variables is always more error prone than just calculating that state. Instead you can add four private functions that calculate these states.

mikes-gh · 2022-12-19T22:11:30Z

Hi @mckaragoz Will you complete this or should we close.?

mckaragoz · 2022-12-20T06:57:39Z

Hi @mckaragoz Will you complete this or should we close.?

This one is nearly ready, i can do the remainings in this week

Anu6is · 2025-01-23T12:42:03Z

@mckaragoz any intentions of reviving this or should this be closed?

mckaragoz · 2025-01-23T12:44:53Z

Wow does it still remain? I remembered that something was merged about max value. We should check

Anu6is · 2025-01-23T12:57:04Z

The link provided in the issue still breaks, yeah.
https://try.mudblazor.com/snippet/cOcQuHEmgGEoyHfi

github-actions · 2025-07-31T17:48:42Z

Hi, this pull request hasn't had activity in a while and has been marked as stale.

Please reply if you're still working on it!

mckaragoz · 2025-08-02T08:11:54Z

Hi

DatePicker Fix Min and Max Date Implementations

ff6f22b

JonBunator reviewed Mar 13, 2022

View reviewed changes

JonBunator added bug Unexpected behavior or functionality not working as intended needs: tests A maintainer has explicitly asked for associated test cases to be added to this pull request labels Mar 13, 2022

mckaragoz and others added 2 commits March 23, 2022 21:38

Hide Navigation Buttons When Needed

d02067c

Merge branch 'MudBlazor:dev' into DatePickerMinMaxDate

40ed6cb

mckaragoz commented Mar 23, 2022

View reviewed changes

src/MudBlazor/Components/DatePicker/MudBaseDatePicker.razor Outdated Show resolved Hide resolved

mckaragoz changed the title ~~DatePicker: Fix Min and Max Date Implementations~~ DatePicker: Fix Min and Max Date Visual Implementations Mar 23, 2022

Simplified Code

044c600

mckaragoz changed the title ~~DatePicker: Fix Min and Max Date Visual Implementations~~ DatePicker: Fix Min and Max Date Visual Implementations And Fix MaxValue Exceed Crash Bug Mar 24, 2022

mckaragoz commented Mar 24, 2022

View reviewed changes

mikes-gh changed the title ~~DatePicker: Fix Min and Max Date Visual Implementations And Fix MaxValue Exceed Crash Bug~~ MudDatePicker: Fix Min and Max Date Visual Implementations And Fix MaxValue Exceed Crash Bug Sep 13, 2022

henon changed the title ~~MudDatePicker: Fix Min and Max Date Visual Implementations And Fix MaxValue Exceed Crash Bug~~ MudDatePicker: Fix Display of Min and Max Date and MaxValue Crash Dec 10, 2022

henon requested changes Dec 10, 2022

View reviewed changes

gaplin mentioned this pull request Mar 7, 2023

MudDatePicker: Add disabled functionality for months only picker #6438

Merged

6 tasks

github-actions bot added the stale Issue or PR has had no activity and is subject to automatic closure if not updated label Jul 31, 2025

github-actions bot added awaiting triage Needs maintainer review or assistance and removed stale Issue or PR has had no activity and is subject to automatic closure if not updated labels Aug 3, 2025

danielchalmers removed the awaiting triage Needs maintainer review or assistance label Aug 17, 2025

Uh oh!

Conversation

mckaragoz commented Mar 2, 2022

Description

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

codecov bot commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JonBunator left a comment

Choose a reason for hiding this comment

Uh oh!

mckaragoz commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mckaragoz commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mckaragoz Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

mckaragoz Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

henon Dec 10, 2022

Choose a reason for hiding this comment

Uh oh!

henon left a comment

Choose a reason for hiding this comment

Uh oh!

henon Dec 10, 2022

Choose a reason for hiding this comment

Uh oh!

mikes-gh commented Dec 19, 2022

Uh oh!

mckaragoz commented Dec 20, 2022

Uh oh!

Anu6is commented Jan 23, 2025

Uh oh!

mckaragoz commented Jan 23, 2025

Uh oh!

Anu6is commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

mckaragoz commented Aug 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Mar 2, 2022 •

edited

Loading

mckaragoz commented Mar 23, 2022 •

edited

Loading

mckaragoz commented Mar 24, 2022 •

edited

Loading

Anu6is commented Jan 23, 2025 •

edited

Loading