Conversation
HClausing
changed the title
|
Here is some feedback: I think we should remove the checkbox from the footer
Also I am not entirely satisfied how the header row and the footer row look. Right now a footer is immediately followed by a header without any spacing between them. This is quite puzzling on first glance. I suggest we look how other toolkits do it to find a good default look for row groups with header and footer. |
|
The presentation problem is even more apparent when you look at multi-level grouping:
|
|
Thanks. I appreciate your feedback, and I totally agree. I'll try find a more elegant way to present the rows when using group footer. |
|
Would you mind renaming MudTGroupRow to MudTableGroupRow ? |
|
Good ideia. I'll rename |
|
The current MudTable Grouping behavior (every group header is gray but my gif is under low color quality, sorry):
|
|
It looks a lot better already. I love the expandable function. However I think like this it would be even better (I quickly threw this sketch together):
I am talking about the order of the expansion icon and the checkbox. Also the example would be so much more intuitive if we would group by the big element groups: Metals, Non-metals, etc. I know it is more work, but it would be a wow-effect. |
|
Actually it is not much work because we have the |
Oh really, I've inverted the order 🙄. I'm working on it, and the biggest challenge is about to get the ensure the correct indentation without break the column width. |
…and footer templates. Also added overflow-y:auto to mud-table-container css class to avoid rows getting outsite from table container when table has fixed height, or doesn't use fixed header neither horizontal scrollbar
…ven if MultiSelect is true.
- Removed MultiSelection checkbox from Footer Row; - Removed gray background stylee on Footer Rows from Docs.
- Added Expandable parameter. - Added tests for Indentation and Expandable.
Changed GroupExpander Toogle and MultiSelection Checkbox to the sasme Tr column; Fixed some misalignment when Indent is active; Fixed header row that was being rendered as MudTd instead of MudTr Some updates on examples.
|
After sosme days testing and rendering, I've made some progress:
Now, about the empty space between expander toggle / checkbox and first column, I guess a better looking will be only possible when the PR #1110 ne merged, because will be possible to override the MudTd of the first column adding these components before.
Note: Footer margin doesn't work when Dense layout is active. |
|
It looks awesome! |
Thanks! |
|
@mikes-gh @Garderoben do you think this is OK to be merged now? |
Design wise, YES! |
|
Many many thanks! |
|
Wonderful! Thanks. |
|
@HClausing The guys from PVS found a bug in razor that was added in this PR, see https://pvs-studio.com/en/blog/posts/csharp/1023/ I have commented above accordingly. |
henon
added
the
legendary
4 participants
Grouping feature for MudTable, with Group Header and Footer Rows, allowing Summaries on both.
It works on recursive way, so it's possible to have unlimited inner groups.
Proposal for #1475 , and replacement for #1879.
Also added overflow-y:auto to mud-table-container css class to avoid rows getting outsite from table container when table has fixed height, or doesn't use fixed header neither horizontal scrollbar. Example here: https://try.mudblazor.com/snippet/GOcFYqlCavftHnBY
Reviews are always welcome.