Skip to content

MudProgressCircular, MudProgressLinear: Add aria-busy attribute#12586

Merged
danielchalmers merged 6 commits intodevfrom
copilot/add-aria-busy-to-progress-indicator
Jan 31, 2026
Merged

MudProgressCircular, MudProgressLinear: Add aria-busy attribute#12586
danielchalmers merged 6 commits intodevfrom
copilot/add-aria-busy-to-progress-indicator

Conversation

Copy link
Contributor

Copilot AI commented Jan 31, 2026 •
edited by danielchalmers
Loading

Progress indicators should signal aria-busy to assistive technologies per WCAG recommendations.

Changes

  • Added dynamic aria-busy attribute

    • "true" when Indeterminate or Value < Max (progress ongoing)
    • "false" when Value >= Max (progress complete)

  • Added tests for aria-busy behavior across states

Example

<!-- Value=50, Max=100 → aria-busy="true" -->
<MudProgressCircular Value="50" />

<!-- Value=100, Max=100 → aria-busy="false" -->
<MudProgressCircular Value="100" />

<!-- Indeterminate always → aria-busy="true" -->
<MudProgressCircular Indeterminate="true" />
Original prompt

This section details on the original issue you should resolve

<issue_title>Set aria-busy on MudProgressCircular to meet WCAG accessibility recommendations.</issue_title>
<issue_description>### Describe your idea

It would be useful for busy indicators to set aria-busy, or allow aria-busy to be set if they aren't dedicated to indicating busy regions. aria-busy can be set when updating regions.

Example code and screenshots

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Set aria-busy on MudProgressCircular for accessibility Add aria-busy attribute to MudProgressCircular for WCAG accessibility Jan 31, 2026
Copilot AI requested a review from ScarletKuro January 31, 2026 20:58
@danielchalmers danielchalmers marked this pull request as ready for review January 31, 2026 21:13
@mudbot mudbot bot changed the title Add aria-busy attribute to MudProgressCircular for WCAG accessibility MudProgressCircular: Add aria-busy attribute for WCAG accessibility Jan 31, 2026
@mudbot mudbot bot added accessibility Accessibility concerns (ARIA, keyboard, focus, screen readers, contrast) enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library labels Jan 31, 2026
@danielchalmers danielchalmers marked this pull request as draft January 31, 2026 21:25
ScarletKuro
ScarletKuro reviewed Jan 31, 2026
View reviewed changes
@ScarletKuro
Copy link
Member

ScarletKuro commented Jan 31, 2026 •
edited
Loading

Maybe we should consider adding internal helper in future, in my projects I use:

public static string StringAttribute(this bool value) => value ? "true" : "false";

less instructions than ToString().ToLowerInvariant()

@ScarletKuro ScarletKuro marked this pull request as ready for review January 31, 2026 22:45
@danielchalmers danielchalmers changed the title MudProgressCircular: Add aria-busy attribute for WCAG accessibility MudProgressCircular, MudProgressLinear: Add aria-busy attribute for WCAG accessibility Jan 31, 2026
@danielchalmers danielchalmers changed the title MudProgressCircular, MudProgressLinear: Add aria-busy attribute for WCAG accessibility MudProgressCircular, MudProgressLinear: Add aria-busy attribute Jan 31, 2026
@danielchalmers danielchalmers merged commit 04de185 into dev Jan 31, 2026
6 checks passed
@ScarletKuro ScarletKuro deleted the copilot/add-aria-busy-to-progress-indicator branch January 31, 2026 23:03
@dependabot dependabot bot mentioned this pull request Feb 11, 2026
Closed
@ScarletKuro ScarletKuro mentioned this pull request Feb 11, 2026
Open
9 tasks
@dependabot dependabot bot mentioned this pull request Feb 12, 2026
Merged
This was referenced Feb 20, 2026
Closed
Open
This was referenced Feb 23, 2026
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Merged
Closed
Open
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Open
Open
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro left review comments

@danielchalmers danielchalmers Awaiting requested review from danielchalmers

Assignees

@ScarletKuro ScarletKuro

Copilot code review Copilot

Labels

accessibility Accessibility concerns (ARIA, keyboard, focus, screen readers, contrast) enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set aria-busy on MudProgressCircular to meet WCAG accessibility recommendations.

3 participants

@ScarletKuro @danielchalmers