Skip to content

MudSelect: Replace async void with Task#12539

Merged
ScarletKuro merged 4 commits intodevfrom
select_async
Jan 26, 2026
Merged

MudSelect: Replace async void with Task#12539
ScarletKuro merged 4 commits intodevfrom
select_async

Conversation

@ScarletKuro
Copy link
Member

Checklist:

  • I've read the contribution guidelines
  • My code follows the style of this project
  • I've added or updated relevant unit tests

@ScarletKuro
Copy link
Member Author

@copilot investigate why d565b5c commit breaks tests, and fix MudSelect so that it can work with this methods being async task and not async void before this commit (with async void all tests worked but we can't go back to this anymore as async void is prohibited in the code base)

Copy link
Contributor

Copilot AI commented Jan 26, 2026

@ScarletKuro I've opened a new pull request, #12540, to work on those changes. Once the pull request is ready, I'll request review from you.

@mudbot mudbot bot added the bug Unexpected behavior or functionality not working as intended label Jan 26, 2026
Copilot AI and others added 3 commits January 26, 2026 18:04
@ScarletKuro ScarletKuro marked this pull request as ready for review January 26, 2026 16:18
@ScarletKuro ScarletKuro requested a review from versile2 as a code owner January 26, 2026 16:18
@ScarletKuro ScarletKuro changed the title MudSelect: Fix async void MudSelect: Replace async void with Task Jan 26, 2026
@ScarletKuro ScarletKuro merged commit 1163590 into dev Jan 26, 2026
5 checks passed
@ScarletKuro ScarletKuro deleted the select_async branch January 26, 2026 16:22
This was referenced Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants