Skip to content

Components: SetTextAsync->SetTextCoreAsync, SetValueAsync->SetValueCoreAsync#12489

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:core_rename
Jan 18, 2026
Merged

Components: SetTextAsync->SetTextCoreAsync, SetValueAsync->SetValueCoreAsync#12489
ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro:core_rename

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Jan 18, 2026

Follow up: #12484

I think that naming is actually more clean and make sense for a protected methods, and now you can make own SetValueAsync SetTextAsync that might not even cross paths.

Checklist:

  • I've read the contribution guidelines
  • My code follows the style of this project
  • I've added or updated relevant unit tests

@mudbot mudbot bot added the refactor Reorganizes code and has no changes to the API or functionality in the main library label Jan 18, 2026
Copy link
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better names for protected members 👍

@danielchalmers danielchalmers added breaking change This change will require consumer code updates and removed refactor Reorganizes code and has no changes to the API or functionality in the main library labels Jan 18, 2026
@ScarletKuro ScarletKuro merged commit 04d5eb8 into MudBlazor:dev Jan 18, 2026
5 of 6 checks passed
@ScarletKuro ScarletKuro deleted the core_rename branch January 18, 2026 19:15
@ScarletKuro ScarletKuro mentioned this pull request Feb 11, 2026
9 tasks
This was referenced Feb 20, 2026
This was referenced Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This change will require consumer code updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants