MudProgressLinear: Add ShowBackground#12443
Conversation
|
@ScarletKuro What does the [AttributeUsage(AttributeTargets.Property)]
public class ParameterStateAttribute : Attribute
{
public ParameterUsageOptions ParameterUsage { get; set; } = ParameterUsageOptions.All;
}
[Flags]
public enum ParameterUsageOptions
{
None = 0,
Read = 1 << 1,
Write = 1 << 2,
All = Read | Write
} |
danielchalmers
left a comment
There was a problem hiding this comment.
Seems reasonable. Could you revert the other changes/cleanup to keep the diff minimal?
|
@danielchalmers For future PRs: Should I always create a separate PR for cleanups or do you don't want cleanups at all? |
We usually don't do separate PRs - might make the changes when the code in a PR naturally touches those areas. Like if this was a bigger feature it would blend in fine, but for something small it's nice to have bite-sized PRs. |
src/MudBlazor.Docs/Pages/Components/Progress/ProgressPage.razor
Outdated
Show resolved
Hide resolved
This is when you use ParameterState. Adding The other options don’t do anything yet, except that |
danielchalmers
left a comment
There was a problem hiding this comment.
Yes, let's flip it from TransparentBackground to ShowBackground. The implementation looks good 👍
danielchalmers
left a comment
There was a problem hiding this comment.
Great! If you could update title/description I'll merge
|
Thank you! |

This PR adds the parameter

ShowBackgroundtoMudProgressLinearwhich allows you to hide the background of the pb: