Skip to content

MudRipple: Provide immediate visual feedback#12409

Merged
Garderoben merged 7 commits intoMudBlazor:devfrom
danielchalmers:ripple-feedback
Jan 12, 2026
Merged

MudRipple: Provide immediate visual feedback#12409
Garderoben merged 7 commits intoMudBlazor:devfrom
danielchalmers:ripple-feedback

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Jan 11, 2026

Closes #8488

Before and after (single click, multi click, holding click)

Video6.mp4
Video7.mp4

After on touch devices:

Video8.mp4

Checklist:

  • I've read the contribution guidelines
  • My code follows the style of this project
  • I've added or updated relevant unit tests

@mudbot mudbot bot added the enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library label Jan 11, 2026
@danielchalmers danielchalmers changed the title Ripple: Provide immediate visual feedback MudRipple: Provide immediate visual feedback Jan 11, 2026
@danielchalmers danielchalmers marked this pull request as ready for review January 11, 2026 19:55
@danielchalmers danielchalmers requested a review from henon January 11, 2026 20:01
Copy link
Contributor

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now on pointerDown instead of pointerUp right? This is one of my long-standing requests back from 2020 which were always turned down using bogus arguments. I like the change.

@henon
Copy link
Contributor

henon commented Jan 12, 2026

See #157 (comment)

@danielchalmers
Copy link
Member Author

It's now on pointerDown instead of pointerUp right? This is one of my long-standing requests back from 2020 which were always turned down using bogus arguments. I like the change.

See #157 (comment)

Also, right now the ripple is on mouse up which is incorrect too. It should start on mouse down and should not go away until you release the mouse. releasing inside the button clicks it. outside it doesn't.

Exactly! Now you'll see the ripple when you start holding the pointer and it won't go away til you let go.

@Garderoben
Copy link
Member

It's now on pointerDown instead of pointerUp right? This is one of my long-standing requests back from 2020 which were always turned down using bogus arguments. I like the change.

Let's refrain from characterizing past decisions as 'bogus.' In 2020, we operated under a 'no JS unless absolutely necessary' policy and prioritized the working pure-CSS version we had at the time.

@Garderoben Garderoben merged commit 70316f0 into MudBlazor:dev Jan 12, 2026
6 checks passed
@meenzen
Copy link
Contributor

meenzen commented Jan 12, 2026

I don't like this change since now the ripple doesn't correspond to button activation anymore. For example when holding the mouse button after a misclick you can move the pointer off the button. This causes the button not to be activated while the ripple still shows up. This is bad UX in my opinion.

@henon
Copy link
Contributor

henon commented Jan 13, 2026

I analyzed this back then and most libraries worked like that. And I would say it is working the same as the good old 3D-buttons. They would visually depress on Mouse-Down but activate only on Mouse-Up. You could press them and move the mouse away and they would not activate. If the ripple works exactly like that it would make a lot of sense to most IMO.

This was referenced Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ripple effect should provide immediate visual feedback

4 participants