MudRipple: Provide immediate visual feedback#12409
Conversation
e300b72 to
b75b3e2
Compare
henon
left a comment
There was a problem hiding this comment.
It's now on pointerDown instead of pointerUp right? This is one of my long-standing requests back from 2020 which were always turned down using bogus arguments. I like the change.
|
See #157 (comment) |
Exactly! Now you'll see the ripple when you start holding the pointer and it won't go away til you let go. |
Let's refrain from characterizing past decisions as 'bogus.' In 2020, we operated under a 'no JS unless absolutely necessary' policy and prioritized the working pure-CSS version we had at the time. |
|
I don't like this change since now the ripple doesn't correspond to button activation anymore. For example when holding the mouse button after a misclick you can move the pointer off the button. This causes the button not to be activated while the ripple still shows up. This is bad UX in my opinion. |
|
I analyzed this back then and most libraries worked like that. And I would say it is working the same as the good old 3D-buttons. They would visually depress on Mouse-Down but activate only on Mouse-Up. You could press them and move the mouse away and they would not activate. If the ripple works exactly like that it would make a lot of sense to most IMO. |
Closes #8488
Before and after (single click, multi click, holding click)
Video6.mp4
Video7.mp4
After on touch devices:
Video8.mp4
Checklist: